Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/resource oracle database cloud vm cluster #11961

Conversation

tulika-aakriti
Copy link
Contributor

Part of: hashicorp/terraform-provider-google#19701

Release Note Template for Downstream PRs (will be copied)

`google_oracle_database_cloud_vm_cluster`

Copy link

github-actions bot commented Oct 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from hao-nan-li October 9, 2024 19:39
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2361 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2361 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 567 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 280 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_vm_cluster" "primary" {
  properties {
    data_storage_size_tb    = # value needed
    db_node_storage_size_gb = # value needed
    db_server_ocids         = # value needed
    diagnostics_data_collection_options {
      diagnostics_events_enabled = # value needed
      health_monitoring_enabled  = # value needed
      incident_logs_enabled      = # value needed
    }
    memory_size_gb = # value needed
    time_zone {
      version = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterBasicExample
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterBasicExample[Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@tulika-aakriti tulika-aakriti marked this pull request as draft October 9, 2024 19:54
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2370 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2370 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 567 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 282 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_vm_cluster" "primary" {
  properties {
    data_storage_size_tb    = # value needed
    db_node_storage_size_gb = # value needed
    db_server_ocids         = # value needed
    diagnostics_data_collection_options {
      diagnostics_events_enabled = # value needed
      health_monitoring_enabled  = # value needed
      incident_logs_enabled      = # value needed
    }
    memory_size_gb = # value needed
    time_zone {
      version = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterBasicExample
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterBasicExample[Debug log]
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@tulika-aakriti tulika-aakriti marked this pull request as ready for review October 10, 2024 17:13
@github-actions github-actions bot requested a review from hao-nan-li October 11, 2024 17:37
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2370 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2370 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 567 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 282 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_vm_cluster" "primary" {
  properties {
    data_storage_size_tb    = # value needed
    db_node_storage_size_gb = # value needed
    db_server_ocids         = # value needed
    diagnostics_data_collection_options {
      diagnostics_events_enabled = # value needed
      health_monitoring_enabled  = # value needed
      incident_logs_enabled      = # value needed
    }
    memory_size_gb = # value needed
    time_zone {
      version = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@hao-nan-li
Copy link
Contributor

Could you add the missing fields to your tests? Just to make sure every field is covered.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2400 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2400 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 567 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 297 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_vm_cluster" "primary" {
  properties {
    time_zone {
      version = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@tulika-aakriti
Copy link
Contributor Author

/gcbrun

1 similar comment
@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2401 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2401 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 567 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 297 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_vm_cluster" "primary" {
  properties {
    time_zone {
      version = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@hao-nan-li
Copy link
Contributor

I think version is still needed for the tests

@tulika-aakriti
Copy link
Contributor Author

I think version is still needed for the tests

I couldn't find any similar example with version, if it's a blocker I can remove the field from yaml file itself as it's not a required field for our API.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2400 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2400 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 567 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 297 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_vm_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_vm_cluster" "primary" {
  properties {
    time_zone {
      version = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

also removed version from time_zone field as partner
api doesn't send it in response so it's a noOp
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2377 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2377 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 556 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 297 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterBasicExample
  • TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterBasicExample[Debug log]
TestAccOracleDatabaseCloudVmCluster_oracledatabaseCloudVmclusterFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@hao-nan-li hao-nan-li merged commit 5529102 into GoogleCloudPlatform:main Oct 14, 2024
13 checks passed
@tulika-aakriti tulika-aakriti deleted the feature/resource_oracle_database_cloud_vm_cluster branch October 14, 2024 18:08
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants