-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/resource oracle database cloud vm cluster #11961
Feature/resource oracle database cloud vm cluster #11961
Conversation
…database_cloud_vm_cluster
…database_cloud_vm_cluster
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_vm_cluster" "primary" {
properties {
data_storage_size_tb = # value needed
db_node_storage_size_gb = # value needed
db_server_ocids = # value needed
diagnostics_data_collection_options {
diagnostics_events_enabled = # value needed
health_monitoring_enabled = # value needed
incident_logs_enabled = # value needed
}
memory_size_gb = # value needed
time_zone {
version = # value needed
}
}
}
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_vm_cluster" "primary" {
properties {
data_storage_size_tb = # value needed
db_node_storage_size_gb = # value needed
db_server_ocids = # value needed
diagnostics_data_collection_options {
diagnostics_events_enabled = # value needed
health_monitoring_enabled = # value needed
incident_logs_enabled = # value needed
}
memory_size_gb = # value needed
time_zone {
version = # value needed
}
}
}
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
…database_cloud_vm_cluster
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_vm_cluster" "primary" {
properties {
data_storage_size_tb = # value needed
db_node_storage_size_gb = # value needed
db_server_ocids = # value needed
diagnostics_data_collection_options {
diagnostics_events_enabled = # value needed
health_monitoring_enabled = # value needed
incident_logs_enabled = # value needed
}
memory_size_gb = # value needed
time_zone {
version = # value needed
}
}
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Could you add the missing fields to your tests? Just to make sure every field is covered. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_vm_cluster" "primary" {
properties {
time_zone {
version = # value needed
}
}
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
/gcbrun |
1 similar comment
/gcbrun |
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_vm_cluster" "primary" {
properties {
time_zone {
version = # value needed
}
}
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
I think |
I couldn't find any similar example with version, if it's a blocker I can remove the field from yaml file itself as it's not a required field for our API. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_vm_cluster" "primary" {
properties {
time_zone {
version = # value needed
}
}
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
🟢 All tests passed! View the build log |
also removed version from time_zone field as partner api doesn't send it in response so it's a noOp
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Part of: hashicorp/terraform-provider-google#19701
Release Note Template for Downstream PRs (will be copied)