Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max threshold permitted in ServiceLevelObjectives #11248

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

etruong42
Copy link
Member

@etruong42 etruong42 commented Jul 24, 2024

https://cloud.google.com/monitoring/api/ref_v3/rest/v3/services.serviceLevelObjectives#resource:-servicelevelobjective indicate that the threshold can now be .9999

Fixes hashicorp/terraform-provider-google#18556

Release Note Template for Downstream PRs (will be copied)

monitoring: updated max threshold permitted in google_monitoring_slo to 0.9999

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 56
Passed tests: 53
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • monitoring

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@etruong42
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceLevelObjective(SLO) goal limit should be increased to 0.9999
3 participants