Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceLevelObjective(SLO) goal limit should be increased to 0.9999 #18556

Comments

@AmirBagaon
Copy link

AmirBagaon commented Jun 26, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version & Provider Version(s)

Terraform v0.14.6
on linux amd64

  • provider registry.terraform.io/hashicorp/google v4.30.0

Affected Resource(s)

google_monitoring_slo

Terraform Configuration

Debug Output

No response

Expected Behavior

Recently Google updated their SLO goal to be in range of 0 < goal <= 0.9999.

Link.

Actual Behavior

Error: goal 0.999900 must be > 0 and <= 0.999

Steps to reproduce

  1. terraform apply

Important Factoids

No response

References

No response

b/354712173

@AmirBagaon AmirBagaon added the bug label Jun 26, 2024
@github-actions github-actions bot added forward/review In review; remove label to forward service/monitoring-services labels Jun 26, 2024
@ggtisc ggtisc self-assigned this Jun 27, 2024
@ggtisc
Copy link
Collaborator

ggtisc commented Jun 27, 2024

Hi @AmirBagaon!

Everything is ok according to the link you're sharing.

So if this is a proposal for an enhancement please confirm this, but if that isn't the case share with us your terraform code and your output.

@AmirBagaon
Copy link
Author

AmirBagaon commented Jun 27, 2024

Thanks for the answer.
It seems that the current abillity of terraform is to support a SLO goal of up to 0.999 but not 0.9999. goal - (Required) The fraction of service that must be good in order for this objective to be met. 0 < goal <= 0.999
Link.

Google recently updated it from 0.999 to 0.9999, as can be seen in the link I provided: The fraction of service that must be good in order for this objective to be met. 0 < goal <= 0.9999.

If terraform does support a 0.9999 goal, can you please share a link to the release notes?

@ggtisc
Copy link
Collaborator

ggtisc commented Jun 28, 2024

@AmirBagaon according to the documentation on terraform registry it is what it is. On the other hand, if you have any official Google source that indicates otherwise, please share it to verify the topic.

@Khemi2024
Copy link

Khemi2024 commented Jul 18, 2024

Hi @ggtisc, I can confirm that we can configure the SLO goal to: 0.999<goal<0.9999 (i.e 0.9995) via the UI and rest but unable to do so through Terraform like @AmirBagaon mentioned.

Are you able to confirm whether the plan is to update Terraform to match the ability the console and rest offers in terms of SLO goal boundaries and if not then the reasoning would be appreciated.

Thanks

@ggtisc
Copy link
Collaborator

ggtisc commented Jul 22, 2024

Confirmed issue!

In Google Cloud documentation the value of the goal could be 0.9999 while in terraform can only be 0.999

@etruong42
Copy link

Possible fix: GoogleCloudPlatform/magic-modules#11248

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.