-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceLevelObjective(SLO) goal limit should be increased to 0.9999 #18556
ServiceLevelObjective(SLO) goal limit should be increased to 0.9999 #18556
Comments
Hi @AmirBagaon! Everything is ok according to the link you're sharing. So if this is a proposal for an enhancement please confirm this, but if that isn't the case share with us your |
Thanks for the answer. Google recently updated it from 0.999 to 0.9999, as can be seen in the link I provided: If terraform does support a 0.9999 goal, can you please share a link to the release notes? |
@AmirBagaon according to the documentation on terraform registry it is what it is. On the other hand, if you have any official Google source that indicates otherwise, please share it to verify the topic. |
Hi @ggtisc, I can confirm that we can configure the SLO goal to: 0.999<goal<0.9999 (i.e 0.9995) via the UI and rest but unable to do so through Terraform like @AmirBagaon mentioned. Are you able to confirm whether the plan is to update Terraform to match the ability the console and rest offers in terms of SLO goal boundaries and if not then the reasoning would be appreciated. Thanks |
Confirmed issue! In Google Cloud documentation the value of the goal could be 0.9999 while in terraform can only be 0.999 |
Possible fix: GoogleCloudPlatform/magic-modules#11248 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Terraform Version & Provider Version(s)
Terraform v0.14.6
on linux amd64
Affected Resource(s)
google_monitoring_slo
Terraform Configuration
Debug Output
No response
Expected Behavior
Recently Google updated their SLO goal to be in range of 0 < goal <= 0.9999.
Link.
Actual Behavior
Error: goal 0.999900 must be > 0 and <= 0.999
Steps to reproduce
terraform apply
Important Factoids
No response
References
No response
b/354712173
The text was updated successfully, but these errors were encountered: