[Terraform] clarify docs around service account id #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
rileykarson
approved these changes
Dec 13, 2018
|
|
||
| members = [ | ||
| "user:[email protected]", | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| resource "google_service_account" "sa" { |
There was a problem hiding this comment.
🤦♀️ did we not have accounts in the examples yet
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
tf-2180-service-acct-docs
branch
from
fe27daf to
388c46c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes hashicorp/terraform-provider-google#2180.
[all]
[terraform]
clarify docs around service account id
[terraform-beta]
[ansible]
[inspec]