Run acceptance and unit tests when test fixtures change #10483
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
| @@ -292,7 +292,7 @@ func modifiedPackages(newBranch, oldBranch string, rnr ExecRunner) (map[string]s | |||
| } | |||
| var goFiles []string | |||
| for _, line := range strings.Split(diffs, "\n") { | |||
| if strings.HasSuffix(line, ".go") || line == "go.mod" || line == "go.sum" { | |||
| if strings.HasSuffix(line, ".go") || strings.Contains(line, "test-fixtures") || line == "go.mod" || line == "go.sum" { | |||
There was a problem hiding this comment.
I see that the bash version of this is matching against go.mod$ - why is that? Should we use HasSuffix here?
There was a problem hiding this comment.
I don't think there's any particular reason other than that the other pattern ends in $. We don't have any other files that end with go.mod or go.sum.
There was a problem hiding this comment.
Oh, never mind. I forgot the line contains the full path of the file.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
fixes hashicorp/terraform-provider-google#17906
Release Note Template for Downstream PRs (will be copied)