Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run downstream tests (unit & acceptance) if test fixtures are modified #17906

Closed
melinath opened this issue Apr 18, 2024 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#10483

Comments

@melinath
Copy link
Collaborator

What kind of contribution is this issue about?

Other (specify in details)

Details

GoogleCloudPlatform/magic-modules#10469 had to be reverted due to failures that were not caught because no go files were modified. test-fixtures is a fairly common pattern for storing non-go files used in tests - we should detect changes to those files when deciding whether to run tests on a PR.

References

No response

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants