TeamCity: test utils refactor

[SarahFrench]

This PR:

• updates the test utils used in the tests for the TeamCity config code.
• changes error messages to be framed the correct way

Test utils:

Previously there was a getSubProject function that would retrieve a project that was nested 2 levels deep from a starting project. It was always given the root of the TeamCity project and was used to pull out projects from within the Google or Google Beta projects.

Now, getSubProject does something more logical given its name. You supply a Project and the name of a subproject within it, and it'll return a Project object for that subproject. This can be used to make assertions on, etc.

The original functionality of retrieving a project from 2 levels of nesting is now fulfilled by getNestedProjectFromRoot, which uses getSubProject internally.

This PR refactors existing acceptance tests to use the new test utils.

Error message framing

Messages needed to be rewritten to be pointing out why a given test would fail.

---

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 81 insertions(+), 75 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 76 insertions(+), 83 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 76 insertions(+), 83 deletions(-))

[SarahFrench]

Not having to assert a variable isn't null feels good man

[SarahFrench]

This refactor makes the tests use the new helpers but also updates the tests to include the new 'project sweeper' project

[SarahFrench]

This isn't a refactor of a test, this is just straight-up fixing a test that wasn't iterating over anything; the root project contains no build configurations.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 84 insertions(+), 97 deletions(-))

[shuyama1]

LGTM! 💯

I've also added a new test nonVCRBuildShouldHaveSaveArtifactsToGCS in mmv1/third_party/terraform/.teamcity/tests/build_configuration_features.kt in a recent PR and it probably needs to be updated as well. Let me know if there's anything I can help

[SarahFrench]

I just rebased this branch to get the new stuff from main, and I'll update the new tests

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 91 insertions(+), 104 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 91 insertions(+), 104 deletions(-))

[SarahFrench]

Waiting to merge until after the service and project sweepers run today