Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: Make service sweepers run before project sweepers, assert that in a test #10233

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Mar 19, 2024

Closes hashicorp/terraform-provider-google#17556

This PR makes sure project sweepers enter the build queue after service sweepers do, effectively ensuring that service sweepers run first and the project sweeper build will wait for them to complete before leaving the queue itself.

The desired consequence of this is that all resources that put liens on projects will be removed, so the project sweeper will experience fewer blocks on deleting projects due to liens.

Release Note Template for Downstream PRs (will be copied)


Comment on lines 144 to 139
val stGa = sweeperGa!!.triggers.items[0] as ScheduleTrigger
val cronGa = stGa.schedulingPolicy as ScheduleTrigger.SchedulingPolicy.Cron
val stBeta = sweeperBeta!!.triggers.items[0] as ScheduleTrigger
val cronBeta = stBeta.schedulingPolicy as ScheduleTrigger.SchedulingPolicy.Cron
val stProject = projectSweeper!!.triggers.items[0] as ScheduleTrigger
val cronProject = stProject.schedulingPolicy as ScheduleTrigger.SchedulingPolicy.Cron
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gross and I need to figure out if there's a better way to do this

@modular-magician

This comment has been minimized.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 52 insertions(+), 3 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 52 insertions(+), 3 deletions(-))

@SarahFrench SarahFrench force-pushed the teamcity-sweep-proj-after-services branch from b71e000 to 8aac487 Compare March 25, 2024 18:14
@SarahFrench
Copy link
Contributor Author

Pulled in the update to pom.xml from main to address the automated test issue when downloading dependencies

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 52 insertions(+), 3 deletions(-))

@SarahFrench SarahFrench requested a review from melinath March 27, 2024 22:05
@SarahFrench SarahFrench marked this pull request as ready for review March 27, 2024 22:05
@SarahFrench
Copy link
Contributor Author

Thanks!

@SarahFrench SarahFrench merged commit fbcec50 into main Mar 27, 2024
13 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 27, 2024
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
@SarahFrench SarahFrench deleted the teamcity-sweep-proj-after-services branch June 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project sweeper can fail due to liens
3 participants