-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TeamCity: Make service sweepers run before project sweepers, assert that in a test #10233
Conversation
val stGa = sweeperGa!!.triggers.items[0] as ScheduleTrigger | ||
val cronGa = stGa.schedulingPolicy as ScheduleTrigger.SchedulingPolicy.Cron | ||
val stBeta = sweeperBeta!!.triggers.items[0] as ScheduleTrigger | ||
val cronBeta = stBeta.schedulingPolicy as ScheduleTrigger.SchedulingPolicy.Cron | ||
val stProject = projectSweeper!!.triggers.items[0] as ScheduleTrigger | ||
val cronProject = stProject.schedulingPolicy as ScheduleTrigger.SchedulingPolicy.Cron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gross and I need to figure out if there's a better way to do this
This comment has been minimized.
This comment has been minimized.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
b71e000
to
8aac487
Compare
Pulled in the update to pom.xml from main to address the automated test issue when downloading dependencies |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Thanks! |
Closes hashicorp/terraform-provider-google#17556
This PR makes sure project sweepers enter the build queue after service sweepers do, effectively ensuring that service sweepers run first and the project sweeper build will wait for them to complete before leaving the queue itself.
The desired consequence of this is that all resources that put liens on projects will be removed, so the project sweeper will experience fewer blocks on deleting projects due to liens.
Release Note Template for Downstream PRs (will be copied)