Make workforce pool provider extra attributes tests and examples foll…

…ow intended use case better. (#10616)
GoogleCloudPlatform · May 8, 2024 · c54e690 · c54e690
1 parent 5ac67cc
commit c54e690
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/...m/examples/iam_workforce_pool_provider_extra_attributes_oauth2_config_client_basic.tf.erb b/...m/examples/iam_workforce_pool_provider_extra_attributes_oauth2_config_client_basic.tf.erb
@@ -12,8 +12,8 @@ resource "google_iam_workforce_pool_provider" "<%= ctx[:primary_resource_id] %>"
     "google.subject" = "assertion.sub"
   }
   oidc {
-    issuer_uri        = "https://accounts.thirdparty.com"
-    client_id         = "client-id"
+    issuer_uri        = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/"
+    client_id         = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery"
     web_sso_config {
       response_type             = "CODE"
       assertion_claims_behavior = "MERGE_USER_INFO_OVER_ID_TOKEN_CLAIMS"
@@ -25,7 +25,7 @@ resource "google_iam_workforce_pool_provider" "<%= ctx[:primary_resource_id] %>"
       }
   }
   extra_attributes_oauth2_client {
-    issuer_uri       = "https://accounts.thirdparty.com"
+    issuer_uri       = "https://login.microsoftonline.com/826602fe-2101-470c-9d71-ee1343668989/v2.0"
     client_id        = "client-id"
     client_secret {
         value {

diff --git a/...rm/examples/iam_workforce_pool_provider_extra_attributes_oauth2_config_client_full.tf.erb b/...rm/examples/iam_workforce_pool_provider_extra_attributes_oauth2_config_client_full.tf.erb
@@ -12,8 +12,8 @@ resource "google_iam_workforce_pool_provider" "<%= ctx[:primary_resource_id] %>"
     "google.subject" = "assertion.sub"
   }
   oidc {
-    issuer_uri        = "https://accounts.thirdparty.com"
-    client_id         = "client-id"
+    issuer_uri        = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/"
+    client_id         = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery"
     client_secret {
       value {
         plain_text = "client-secret"
@@ -25,7 +25,7 @@ resource "google_iam_workforce_pool_provider" "<%= ctx[:primary_resource_id] %>"
     }
   }
   extra_attributes_oauth2_client {
-    issuer_uri       = "https://accounts.thirdparty.com"
+    issuer_uri       = "https://login.microsoftonline.com/826602fe-2101-470c-9d71-ee1343668989/v2.0"
     client_id        = "client-id"
     client_secret {
         value {

diff --git a/...arty/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb b/...arty/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb
@@ -443,8 +443,8 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     "google.subject"  = "assertion.sub"
   }
   oidc {
-    issuer_uri        = "https://accounts.thirdparty.com"
-    client_id         = "client-id"
+    issuer_uri        = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/"
+    client_id         = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery"
     client_secret {
       value {
         plain_text = "client-secret"
@@ -457,7 +457,7 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     }
   }
   extra_attributes_oauth2_client {
-    issuer_uri       = "https://accounts.thirdparty.com"
+    issuer_uri       = "https://login.microsoftonline.com/826602fe-2101-470c-9d71-ee1343668989/v2.0"
     client_id        = "client-id"
     client_secret {
         value {
@@ -493,8 +493,8 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     "google.subject"  = "false"
   }
   oidc {
-    issuer_uri        = "https://accounts.thirdparty.com"
-    client_id         = "client-id"
+    issuer_uri        = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/"
+    client_id         = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery"
     client_secret {
       value {
         plain_text = "client-secret"
@@ -507,7 +507,7 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     }
   }
   extra_attributes_oauth2_client {
-    issuer_uri       = "https://accounts.thirdparty.com/new"
+    issuer_uri       = "https://login.microsoftonline.com/826602fe-2101-470c-9d71-ee1343668989/v2.0/"
     client_id        = "new-client-id"
     client_secret {
         value {
@@ -543,8 +543,8 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     "google.subject"  = "false"
   }
   oidc {
-    issuer_uri        = "https://accounts.thirdparty.com"
-    client_id         = "client-id"
+    issuer_uri        = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/"
+    client_id         = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery"
     client_secret {
       value {
         plain_text = "client-secret"
@@ -580,8 +580,8 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     "google.subject"  = "false"
   }
   oidc {
-    issuer_uri        = "https://accounts.thirdparty.com"
-    client_id         = "client-id"
+    issuer_uri        = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/"
+    client_id         = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery"
     client_secret {
       value {
         plain_text = "client-secret"
@@ -594,7 +594,7 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     }
   }
   extra_attributes_oauth2_client {
-    issuer_uri       = "https://accounts.thirdparty.com"
+    issuer_uri       = "https://login.microsoftonline.com/826602fe-2101-470c-9d71-ee1343668989/v2.0"
     client_id        = "client-id"
     client_secret {
         value {