-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make workforce pool provider extra attributes tests and examples follow intended use case better. #10616
Make workforce pool provider extra attributes tests and examples follow intended use case better. #10616
Conversation
…ow intended use case better.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIAMWorkforcePoolWorkforcePoolProvider_extraAttributesOauth2Client|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientBasicExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientFullExample |
|
issuer_uri = "https://accounts.thirdparty.com" | ||
client_id = "client-id" | ||
issuer_uri = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/" | ||
client_id = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you explain how this follows the intended use case better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra_attributes_oauth2_config was recently added for Power BI groups support, see https://cloud.google.com/iam/docs/workforce-sign-in-power-bi#create-workforce-provider. For AZURE_AD_GROUPS_MAIL attribute type, it should have Power BI config or would not work when signing in.
…ow intended use case better. (GoogleCloudPlatform#10616)
…ow intended use case better. (GoogleCloudPlatform#10616)
…ow intended use case better. (GoogleCloudPlatform#10616)
…ow intended use case better. (GoogleCloudPlatform#10616)
…ow intended use case better. (GoogleCloudPlatform#10616)
Make workforce pool provider extra attributes tests and examples follow intended use case better.
Release Note Template for Downstream PRs (will be copied)