Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workforce pool provider extra attributes tests and examples follow intended use case better. #10616

Merged
merged 1 commit into from
May 8, 2024

Conversation

misterpoe
Copy link
Contributor

Make workforce pool provider extra attributes tests and examples follow intended use case better.

Release Note Template for Downstream PRs (will be copied)

Copy link

github-actions bot commented May 7, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 23 insertions(+), 23 deletions(-))
google-beta provider: Diff ( 3 files changed, 23 insertions(+), 23 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 11
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIAMWorkforcePoolWorkforcePoolProvider_extraAttributesOauth2Client|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientBasicExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePoolProvider_extraAttributesOauth2Client[Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientBasicExample[Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

issuer_uri = "https://accounts.thirdparty.com"
client_id = "client-id"
issuer_uri = "https://sts.windows.net/826602fe-2101-470c-9d71-ee1343668989/"
client_id = "https://analysis.windows.net/powerbi/connector/GoogleBigQuery"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain how this follows the intended use case better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra_attributes_oauth2_config was recently added for Power BI groups support, see https://cloud.google.com/iam/docs/workforce-sign-in-power-bi#create-workforce-provider. For AZURE_AD_GROUPS_MAIL attribute type, it should have Power BI config or would not work when signing in.

@BBBmau BBBmau merged commit 5a59431 into GoogleCloudPlatform:main May 8, 2024
13 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants