ACM: notebook controller needs to use istio ingress istio-system/ingressgateway #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essgateway * Related to GoogleCloudPlatform#111
|
This change is |
jlewi
changed the title
|
/assign @Bobgy |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Aug 13, 2020
…use workload identity #109: Update instructions for using ACM. #113: ACM: notebook controller needs to use istio ingress Cherry pick of #105 #109 #113 on v1.1-branch. #105: Management blueprint; add kptfile and use workload identity #109: Update instructions for using ACM. #113: ACM: notebook controller needs to use istio ingress (#122) * Management blueprint; add kptfile and use workload identity mode for CNRM * management/instance needs a Kptfile to work with the latest versions of kpt * Per #13 we don't want to run CNRM in namespace mode because this burdensome instead we use workload identity mode; i.e. the same GCP sa to administer multiple projects. Related to #13 - Use workload identity mode Related to #102 Fix blueprint * Remove cluster and nodepool patches from instance; we aren't actually patching anything. * Update instructions for using ACM. * Use a kpt function to remove namespace from non namespace scoped objects * Use yq to attach backend config to the ingress. * Remove the iap enabler pod; this is a partial work around for #14 * The IAP enabler pod will try to update the ISTIO security policy which will conflict with ACM. So we disable it for now even though that means we have to manually update the health check. * Switch to using a structured repo with ACM (#29) * Add a script to rewrite the YAML files in the appropriate structure * If we don't use a structured repository we end up with problems because resources in different namespaces but with the same name will be written to the same file. * Add a hack to create the kube-system namespace as part of the ACM deployment. * Now that we are using structured repositories we need to have a namespace directory with a namespace.yaml for kube-system in order to install resources in that namespace. Related to #4 - use ACM to deploy Kubeflow * ACM: notebook controller needs to use istio ingress istio-system/ingressgateway * Related to #111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…essgateway