Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM] Support structured repository #29

Open
jlewi opened this issue May 21, 2020 · 3 comments
Open

[ACM] Support structured repository #29

jlewi opened this issue May 21, 2020 · 3 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented May 21, 2020

Currently our ACM story doesn't use a structured repository. The main reason was because
we would need to refactor the manifests; e.g. put ClusterScoped resources in one directory and namespace resources in a different directory.

Could we reorganize the files using a kustomize function?

Using a flat repository will get pretty unmanageable.

Can we use subdirectories with an unstructured repositories?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.77

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

jlewi pushed a commit to jlewi/gcp-blueprints that referenced this issue Aug 2, 2020
* Use a kpt function to remove namespace from non namespace scoped
  objects

* Use yq to attach backend config to the ingress.

* Remove the iap enabler pod; this is a partial work around for GoogleCloudPlatform#14

  * The IAP enabler pod will try to update the ISTIO security policy
    which will conflict with ACM. So we disable it for now even though
    that means we have to manually update the health check.

* Switch to using a structured repo with ACM (GoogleCloudPlatform#29)

  * Add a script to rewrite the YAML files in the appropriate structure

  * If we don't use a structured repository we end up with problems because
    resources in different namespaces but with the same name will be written
    to the same file.

* Add a hack to create the kube-system namespace as part of the ACM deployment.

  * Now that we are using structured repositories we need to have
    a namespace directory with a namespace.yaml for kube-system
    in order to install resources in that namespace.

Related to GoogleCloudPlatform#4 - use ACM to deploy Kubeflow
k8s-ci-robot pushed a commit that referenced this issue Aug 3, 2020
* Use a kpt function to remove namespace from non namespace scoped
  objects

* Use yq to attach backend config to the ingress.

* Remove the iap enabler pod; this is a partial work around for #14

  * The IAP enabler pod will try to update the ISTIO security policy
    which will conflict with ACM. So we disable it for now even though
    that means we have to manually update the health check.

* Switch to using a structured repo with ACM (#29)

  * Add a script to rewrite the YAML files in the appropriate structure

  * If we don't use a structured repository we end up with problems because
    resources in different namespaces but with the same name will be written
    to the same file.

* Add a hack to create the kube-system namespace as part of the ACM deployment.

  * Now that we are using structured repositories we need to have
    a namespace directory with a namespace.yaml for kube-system
    in order to install resources in that namespace.

Related to #4 - use ACM to deploy Kubeflow
@jlewi
Copy link
Contributor Author

jlewi commented Aug 4, 2020

Fixed by #109

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
platform/gcp 0.94

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

jlewi pushed a commit to jlewi/gcp-blueprints that referenced this issue Aug 12, 2020
* Use a kpt function to remove namespace from non namespace scoped
  objects

* Use yq to attach backend config to the ingress.

* Remove the iap enabler pod; this is a partial work around for GoogleCloudPlatform#14

  * The IAP enabler pod will try to update the ISTIO security policy
    which will conflict with ACM. So we disable it for now even though
    that means we have to manually update the health check.

* Switch to using a structured repo with ACM (GoogleCloudPlatform#29)

  * Add a script to rewrite the YAML files in the appropriate structure

  * If we don't use a structured repository we end up with problems because
    resources in different namespaces but with the same name will be written
    to the same file.

* Add a hack to create the kube-system namespace as part of the ACM deployment.

  * Now that we are using structured repositories we need to have
    a namespace directory with a namespace.yaml for kube-system
    in order to install resources in that namespace.

Related to GoogleCloudPlatform#4 - use ACM to deploy Kubeflow
k8s-ci-robot pushed a commit that referenced this issue Aug 13, 2020
…use workload identity #109: Update instructions for using ACM. #113: ACM: notebook controller needs to use istio ingress Cherry pick of #105 #109 #113 on v1.1-branch. #105: Management blueprint; add kptfile and use workload identity #109: Update instructions for using ACM. #113: ACM: notebook controller needs to use istio ingress (#122)

* Management blueprint; add kptfile and use workload identity mode for CNRM

* management/instance needs a Kptfile to work with the latest versions of kpt

* Per #13 we don't want to run CNRM in namespace mode because this burdensome
  instead we use workload identity mode; i.e. the same GCP sa to administer
  multiple projects.

Related to #13 - Use workload identity mode
Related to #102 Fix blueprint

* Remove cluster and nodepool patches from instance; we aren't actually patching anything.

* Update instructions for using ACM.

* Use a kpt function to remove namespace from non namespace scoped
  objects

* Use yq to attach backend config to the ingress.

* Remove the iap enabler pod; this is a partial work around for #14

  * The IAP enabler pod will try to update the ISTIO security policy
    which will conflict with ACM. So we disable it for now even though
    that means we have to manually update the health check.

* Switch to using a structured repo with ACM (#29)

  * Add a script to rewrite the YAML files in the appropriate structure

  * If we don't use a structured repository we end up with problems because
    resources in different namespaces but with the same name will be written
    to the same file.

* Add a hack to create the kube-system namespace as part of the ACM deployment.

  * Now that we are using structured repositories we need to have
    a namespace directory with a namespace.yaml for kube-system
    in order to install resources in that namespace.

Related to #4 - use ACM to deploy Kubeflow

* ACM: notebook controller needs to use istio ingress istio-system/ingressgateway

* Related to #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant