Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests:feat:integ: adc for direct #3386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Dec 13, 2024

This is a companion PR to #3314 but for our integ (post submit) dynamic test suite. Tested out w a resource I am working on. Prior to this change, there's no plumbing for the X-goog-user-project header in the actual test setup.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maqiuyujoyce
Copy link
Collaborator

@acpana have you verified locally for all resources that this config works? I can't be sure if the following logic works for all non-direct resources, so could you use the code from master HEAD to create a baseline test result, and then run the test with this change to ensure the test result is the same (ish)?

	p := testgcp.GetDefaultProject(t)
	// technically this would be sufficient for TF and DCL controllers
	// to set the BillingProject as the resource project that is being used.
	kccConfig.UserProjectOverride = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants