Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests:feat: enable adc #3314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests:feat: enable adc #3314

wants to merge 1 commit into from

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Dec 4, 2024

Small but powerful change to enable us to use APIs that require a quota project to be set. IOW, with this change I can run

$ WRITE_GOLDEN_OUTPUT=1 GOLDEN_REQUEST_CHECKS=1 \
GOLDEN_OBJECT_CHECKS=1 E2E_KUBE_TARGET=envtest RUN_E2E=1 \
E2E_GCP_TARGET=real \
 go test -test.count=1 -timeout 3600s -v ./tests/e2e -run TestAllInSeries/fixtures/bigqueryanalyticshublisting-base  2>&1

and have the direct controller in particular set the right header for x-goog-user-project.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuwenma for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Alex Pana <[email protected]>
@acpana acpana force-pushed the acpana/test-enable-adcs branch from 7c373bc to 7e2683d Compare December 4, 2024 23:29
@jingyih
Copy link
Collaborator

jingyih commented Dec 4, 2024

The dynamic integration test TestCreateNoChangeUpdateDelete for this resource is also failing. Do you know if it is due to the same quota project issue?

@yuwenma
Copy link
Collaborator

yuwenma commented Dec 16, 2024

@maqiuyujoyce Can you take a look at this PR?


// but for our direct resources we look at the BillingProject so let's set it.
if os.Getenv("BILLING_ACCOUNT_ID") != "" {
kccConfig.BillingProject = os.Getenv("BILLING_ACCOUNT_ID")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is the BillingProject here a GCP billing account ID?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants