tests: set 0 llm #3226
Merged
tests: set 0 llm #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold want #3200 to go in first |
acpana
force-pushed
the
acpana/scenarios-refactor
branch
from
cd1d858 to
297aa27
Compare
|
/hold cancel |
yuwenma
reviewed
Nov 25, 2024
yuwenma
reviewed
Dec 3, 2024
| "valueType": "DISTRIBUTION" | ||
| }, | ||
| "name": "logginglogmetric-${uniqueId}", | ||
| "resourceName": "projects/${projectId}/metrics/logginglogmetric-${uniqueId}", |
There was a problem hiding this comment.
super nit: this resourceName seems to be missing in the MockGCP
There was a problem hiding this comment.
Oh good catch -- this might need to be a mock improvement change. I can explore that outside of this PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a scenario test for setting 0 for native types for the LoggingLogMetric.
A few call outs
Note in the future we will want tooling that can generate these tests for us and run against the direct controllers. To that end, both the filler mechanism in the random filler (#3151) and the field analysis tool (#2326) will help.