Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:tests: field management scenario tests #3200

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Nov 19, 2024

A very small refactor to organize the scenario tests around field management.

Copy link
Collaborator

@maqiuyujoyce maqiuyujoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @acpana ! Just one comment about the doc.

tests/e2e/testdata/scenarios/fields/management/README.md Outdated Show resolved Hide resolved
@acpana acpana requested a review from maqiuyujoyce November 20, 2024 17:21
Copy link
Collaborator

@maqiuyujoyce maqiuyujoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@acpana acpana force-pushed the acpana/scenarios-refactor branch from cd1d858 to 297aa27 Compare November 20, 2024 22:14
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 20, 2024
@maqiuyujoyce
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 20, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 28b20a1 into master Nov 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants