Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Spelling 11/n #3219

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ repo to quickly set up a local dev environment.
```shell
./gcp-setup.sh
```
1. _(Optional)_ Verify that worload identity federation is [setup correctly](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#verify_the_setup).
1. _(Optional)_ Verify that workload identity federation is [setup correctly](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#verify_the_setup).

1. Now that you have everything set up, you can build your own images and then
deploy the Config Connector CRDs and workloads (including controller
Expand Down
2 changes: 1 addition & 1 deletion config/tests/samples/create/harness.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func NewHarness(ctx context.Context, t *testing.T, opts ...HarnessOption) *Harne
if targetKube := os.Getenv("E2E_KUBE_TARGET"); targetKube == "envtest" {
whCfgs, err := testwebhook.GetTestCommonWebhookConfigs()
if err != nil {
h.Fatalf("error getting common wehbook configs: %v", err)
h.Fatalf("error getting common webhook configs: %v", err)
}
webhooks = append(webhooks, whCfgs...)

Expand Down
2 changes: 1 addition & 1 deletion crds/dns_v1beta1_dnsrecordset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ spec:
type: string
routingPolicy:
description: The configuration for steering traffic based on query.
You can specify either Weighted Round Robin(WRR) type or Geolocation (GEO)
You can specify either Weighted Round Robin (WRR) type or Geolocation (GEO)
type.
properties:
enableGeoFencing:
Expand Down
2 changes: 1 addition & 1 deletion operator/tests/e2e/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ func TestUpgrade(t *testing.T) {
}
time.Sleep(120 * time.Second) // Some buffer time for the operator to reconcile on the existing ConfigConnector
if err := cluster.waitForConfigConnectorToBeHealthy(k8s.ConfigConnectorAllowedName); err != nil {
t.Fatal(fmt.Errorf("error waitting for ConfigConnector to be healthy: %w", err))
t.Fatal(fmt.Errorf("error waiting for ConfigConnector to be healthy: %w", err))
}
checkIfKCCHasUpgradedToTheLatestVersion(t, cluster, log)
log.Info("Re-applying ArtifactRegistryRepository")
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/direct/logging/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -276,11 +276,11 @@ func compareLinearBuckets(kccObj *krm.LogmetricLinearBuckets, apiObj *api.Linear
apiLinearBuckets := struct {
numFiniteBuckets int64
offset float64
witdh float64
width float64
}{
numFiniteBuckets: apiObj.NumFiniteBuckets,
offset: apiObj.Offset,
witdh: apiObj.Width,
width: apiObj.Width,
}

return reflect.DeepEqual(kccObj, apiLinearBuckets)
Expand Down
2 changes: 1 addition & 1 deletion pkg/test/main/testmain.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func SetupMultipleEnvironments(m *testing.M, testType test.Type, crds []*apiexte
if testType == test.IntegrationTestType {
whCfgs, err = webhook.GetTestCommonWebhookConfigs()
if err != nil {
log.Fatalf("error getting common wehbook configs: %v", err)
log.Fatalf("error getting common webhook configs: %v", err)
}
}
env := testenvironment.StartTestEnvironmentOrLogFatal(testType, crds, whCfgs)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
settings:
activationPolicy: ALWAYS
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
settings:
activationPolicy: NEVER
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
settings:
activationPolicy: ALWAYS
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
settings:
activationPolicy: NEVER
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
name: secret-${uniqueId}
settings:
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
name: secret-${uniqueId}
settings:
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
name: secret-${uniqueId}
settings:
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
name: secret-${uniqueId}
settings:
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
value: 0.0.0.0/0
expirationTime: 2099-01-01T00:00:00Z
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
value: 1.2.3.0/24
expirationTime: 2100-01-01T00:00:00Z
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
value: 0.0.0.0/0
expirationTime: 2099-01-01T00:00:00Z
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
value: 1.2.3.0/24
expirationTime: 2100-01-01T00:00:00Z
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
startTime: 00:00
transactionLogRetentionDays: 2
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
startTime: 01:00
transactionLogRetentionDays: 3
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
startTime: 00:00
transactionLogRetentionDays: 2
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
startTime: 01:00
transactionLogRetentionDays: 3
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
startTime: 00:00
transactionLogRetentionDays: 2
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
startTime: 01:00
transactionLogRetentionDays: 3
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
startTime: 00:00
transactionLogRetentionDays: 2
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
startTime: 01:00
transactionLogRetentionDays: 3
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
startTime: 00:00
transactionLogRetentionDays: 2
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
startTime: 00:00
transactionLogRetentionDays: 2
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
settings:
connectorEnforcement: NOT_REQUIRED
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
settings:
connectorEnforcement: REQUIRED
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
settings:
connectorEnforcement: NOT_REQUIRED
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
settings:
connectorEnforcement: REQUIRED
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
- name: log_connections
value: "on"
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
- name: log_timezone
value: "America/Los_Angeles"
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
- name: log_connections
value: "on"
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
- name: log_timezone
value: "America/Los_Angeles"
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
# test case, we will specify `edition: ENTERPRISE` here.
edition: ENTERPRISE
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
# Data cache requires ENTERPRISE_PLUS edition.
edition: ENTERPRISE_PLUS
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
# we must set `edition: ENTERPRISE_PLUS` here.
edition: ENTERPRISE_PLUS
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
# Data cache requires ENTERPRISE_PLUS edition.
edition: ENTERPRISE_PLUS
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
settings:
deletionProtectionEnabled: true
# Location preference is not actually a required field. However, setting it for tests
# helps with with normalizing the GCP responses, because otherwise GCP chooses a zone
# helps with normalizing the GCP responses, because otherwise GCP chooses a zone
# preference based on availability. Therefore it could potentially vary if not
# explicitly specified.
locationPreference:
Expand Down
Loading
Loading