Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Spelling 11/n #3219

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 20, 2024

Change description

Subset of #3062

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsoref jsoref mentioned this pull request Nov 20, 2024
14 tasks
@jsoref
Copy link
Contributor Author

jsoref commented Nov 20, 2024

I tried hack/compare-mock fixtures/regionalcomputetargettcpproxy-direct and got:

diff --git a/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log b/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
index 1c70b18a1..053014c98 100644
--- a/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
+++ b/pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/regionalcomputetargettcpproxy-direct/_http.log
@@ -225,7 +225,7 @@ X-Xss-Protection: 0
 GET https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
 Content-Type: application/json
 User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=${targetTcpProxyID}
 
 404 Not Found
 Cache-Control: private
@@ -335,7 +335,7 @@ X-Xss-Protection: 0
 GET https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
 Content-Type: application/json
 User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=${targetTcpProxyID}
 
 200 OK
 Cache-Control: private
@@ -366,7 +366,7 @@ X-Xss-Protection: 0
 DELETE https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/europe-west4/targetTcpProxies/${targetTcpProxyID}
 Content-Type: application/json
 User-Agent: kcc/controller-manager
-x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=computetargettcpproxy-${uniqueId}
+x-goog-request-params: project=${projectId}&region=europe-west4&target_tcp_proxy=${targetTcpProxyID}
 
 200 OK
 Cache-Control: private

Which seems kinda odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant