Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid changing name of tests #1388

Merged
merged 1 commit into from
Mar 18, 2024
Merged

chore: avoid changing name of tests #1388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/e2e/unified_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func TestAllInSeries(t *testing.T) {
}
})

testFixturesInSeries(ctx, t, "AllInSeries", false, cancel)
testFixturesInSeries(ctx, t, false, cancel)
}

// TestPauseInSeries is a basic smoke test to prove that if CC pauses actuation of resources
Expand All @@ -96,10 +96,10 @@ func TestPauseInSeries(t *testing.T) {
cancel()
})

testFixturesInSeries(ctx, t, "PauseInSeries", true, cancel)
testFixturesInSeries(ctx, t, true, cancel)
}

func testFixturesInSeries(ctx context.Context, t *testing.T, testName string, testPause bool, cancel context.CancelFunc) {
func testFixturesInSeries(ctx context.Context, t *testing.T, testPause bool, cancel context.CancelFunc) {
t.Helper()

if os.Getenv("RUN_E2E") == "" {
Expand All @@ -109,7 +109,7 @@ func testFixturesInSeries(ctx context.Context, t *testing.T, testName string, te
t.Skip("GOLDEN_REQUEST_CHECKS not set; skipping as this test relies on the golden files.")
}

t.Run(fmt.Sprintf("%s/fixtures", testName), func(t *testing.T) {
t.Run("fixtures", func(t *testing.T) {
fixtures := resourcefixture.Load(t)
for _, fixture := range fixtures {
fixture := fixture
Expand Down
Loading