Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid changing name of tests #1388

Merged

Conversation

justinsb
Copy link
Collaborator

I think the test method name (the first component) is sufficient here,
and then we don't need to change the test paths for "normal"
TestAllInSeries.

I think the test method name (the first component) is sufficient here,
and then we don't need to change the test paths for "normal"
TestAllInSeries.
@justinsb justinsb added this to the 1.115 milestone Mar 16, 2024
@justinsb
Copy link
Collaborator Author

/assign @acpana

I don't think we need to change the test name here. I'm not opposed to changing the test path (indeed, I'm proposing we include the GCP service), but it is a bit of work, so I'd rather not change it unless we need to - is there any reason to change the test path here?

@acpana
Copy link
Collaborator

acpana commented Mar 18, 2024

Ah no I goofed here, thanks for simplifying this. A format of TestPauseInSeries/PauseInSeries/fixtures/fullalloydbinstance is redundant 😝 .

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 18, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acpana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bd1977f into GoogleCloudPlatform:master Mar 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants