-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aiplatform): add initial Imagen code sample and test #9422
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
@minherz I'm not sure the tests are running. I don't see individual test cases in the log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update: Code sample look good to me. I hoping for a second reviewer to check the repo's specific code style(if any) & merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits. Kindly address those before merging. Thanks!
aiplatform/src/main/java/aiplatform/imagen/GenerateImageSample.java
Outdated
Show resolved
Hide resolved
aiplatform/src/main/java/aiplatform/imagen/GenerateImageSample.java
Outdated
Show resolved
Hide resolved
aiplatform/src/main/java/aiplatform/imagen/GenerateImageSample.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Sita Lakshmi Sangameswaran <[email protected]>
Description
Fixes #355484599