Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aiplatform): add initial Imagen code sample and test #9422

Merged
merged 11 commits into from
Aug 2, 2024
Merged

feat(aiplatform): add initial Imagen code sample and test #9422

merged 11 commits into from
Aug 2, 2024

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Jul 30, 2024

Description

Fixes #355484599

  • Please merge this PR for me once it is approved

@irataxy irataxy requested review from yoshi-approver and a team as code owners July 30, 2024 02:39
Copy link

snippet-bot bot commented Jul 30, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Jul 30, 2024
@irataxy
Copy link
Contributor Author

irataxy commented Jul 30, 2024

@minherz I'm not sure the tests are running. I don't see individual test cases in the log.

Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar
Copy link
Member

Update: Code sample look good to me. I hoping for a second reviewer to check the repo's specific code style(if any) & merge the PR.

Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits. Kindly address those before merging. Thanks!

@irataxy irataxy merged commit 54a2cfc into GoogleCloudPlatform:main Aug 2, 2024
8 checks passed
@irataxy irataxy deleted the gemini branch August 2, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants