Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use new scope variable in custom-image module #2377

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix: use new scope variable in custom-image module #2377

merged 1 commit into from
Mar 19, 2024

Conversation

nick-stroud
Copy link
Collaborator

Pickup from #2367

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@nick-stroud nick-stroud requested review from tpdownes and cboneti March 19, 2024 15:42
@nick-stroud nick-stroud enabled auto-merge March 19, 2024 15:42
@nick-stroud nick-stroud added the release-chore To not include into release notes label Mar 19, 2024
@cboneti cboneti assigned nick-stroud and unassigned cboneti Mar 19, 2024
@nick-stroud nick-stroud merged commit a270438 into GoogleCloudPlatform:develop Mar 19, 2024
8 of 40 checks passed
@tpdownes tpdownes mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboneti cboneti cboneti approved these changes

@tpdownes tpdownes Awaiting requested review from tpdownes

Assignees

@nick-stroud nick-stroud

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-stroud @cboneti