Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packer service account fix and alignment with Toolkit naming convention #2367

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Packer service account fix and alignment with Toolkit naming convention #2367

merged 3 commits into from
Mar 15, 2024

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Mar 15, 2024 •
edited
Loading

  • Resolve bug where var.service_account_email can be specified but is not actually used by Packer build
    • there is, unfortunately, no obvious Packer equivalent of tflint that would help detect this
  • deprecate var.scopes in favor of var.service_account_scopes to align with rest of Toolkit

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes added the do-not-merge Block merging of this PR label Mar 15, 2024
@tpdownes tpdownes self-assigned this Mar 15, 2024
@tpdownes tpdownes force-pushed the packer_sa branch 4 times, most recently from 51f43a9 to bda22ef Compare March 15, 2024 15:24
@tpdownes tpdownes requested a review from rohitramu March 15, 2024 15:37
@tpdownes tpdownes assigned rohitramu and unassigned tpdownes Mar 15, 2024
@tpdownes tpdownes added release-bugfix Added to release notes under the "Bug fixes" heading. and removed do-not-merge Block merging of this PR labels Mar 15, 2024
@tpdownes tpdownes marked this pull request as ready for review March 15, 2024 15:37
@tpdownes tpdownes added release-chore To not include into release notes release-bugfix Added to release notes under the "Bug fixes" heading. and removed release-chore To not include into release notes release-bugfix Added to release notes under the "Bug fixes" heading. labels Mar 15, 2024
@rohitramu rohitramu assigned tpdownes and unassigned rohitramu Mar 15, 2024
tpdownes added 3 commits March 15, 2024 12:34
@tpdownes
Fix missing assignment of service account in Packer module
0a31dc2
@tpdownes
Align service account scopes naming convention in Packer module with …
8847dff 
…rest of the Toolkit
@tpdownes
Remove service account usage from Packer examples
3d96254 
- hidden bug was causing Packer to always use default Compute Engine
  service account
- IAM bindings do not propagate in time for these examples to work
- minimum IAM bindings are already documented
@tpdownes tpdownes merged commit c8594fa into GoogleCloudPlatform:develop Mar 15, 2024
10 of 40 checks passed
@tpdownes tpdownes deleted the packer_sa branch March 15, 2024 17:52
@nick-stroud nick-stroud mentioned this pull request Mar 19, 2024
Merged
@tpdownes tpdownes mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitramu rohitramu rohitramu approved these changes

Assignees

@tpdownes tpdownes

Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @rohitramu