docs: update documentation of accepted /quitquitquit HTTP methods #2255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 2.7.0, the
/quitquitquit
endpoint was updated to accept GET requests (in addition to POST requests, which it already accepted). See changelog. Also see the PR that made this change, #1947.Recently, while debugging a k8s shutdown problem, I quickly skimmed the readme to check that I was using
/quitquitquit
correctly and became convinced that I wasn't because I was sending a GET request. I had copied the example here, but didn't remember that in the moment:cloud-sql-proxy/examples/k8s-health-check/proxy_with_http_health_check.yaml
Lines 107 to 115 in 848e1ea
Updating the docs to be more complete on this topic.