Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation of accepted /quitquitquit HTTP methods #2255

Merged

Conversation

wolfpeyton
Copy link
Contributor

In version 2.7.0, the /quitquitquit endpoint was updated to accept GET requests (in addition to POST requests, which it already accepted). See changelog. Also see the PR that made this change, #1947.

Recently, while debugging a k8s shutdown problem, I quickly skimmed the readme to check that I was using /quitquitquit correctly and became convinced that I wasn't because I was sending a GET request. I had copied the example here, but didn't remember that in the moment:

# Configure kubernetes to call the /quitquitquit endpoint on the
# admin server before sending SIGTERM to the proxy before stopping
# the pod. This will give the proxy more time to gracefully exit.
lifecycle:
preStop:
httpGet:
path: /quitquitquit
port: 9092
scheme: HTTP

Updating the docs to be more complete on this topic.

@wolfpeyton wolfpeyton requested a review from a team as a code owner June 16, 2024 14:16
@jackwotherspoon jackwotherspoon added the tests: run Label to trigger Github Action tests. label Jun 17, 2024
@github-actions github-actions bot removed the tests: run Label to trigger Github Action tests. label Jun 17, 2024
@jackwotherspoon jackwotherspoon merged commit 757c08f into GoogleCloudPlatform:main Jun 17, 2024
10 checks passed
@jackwotherspoon
Copy link
Collaborator

Thanks @wolfpeyton for this great catch and helping make our docs better for future users! Greatly appreciated 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants