feat: /quitquitquit api now responds to HTTP GET and POST requests. #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
reviewed
Sep 13, 2023
cmd/root_test.go
Outdated
| @@ -1307,7 +1307,7 @@ func TestPProfServer(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestQuitQuitQuit(t *testing.T) { | |||
| func TestQuitQuitQuitHttpPost(t *testing.T) { | |||
cmd/root_test.go
Outdated
| c := NewCommand(WithDialer(&spyDialer{})) | ||
| c.SilenceUsage = true | ||
| c.SilenceErrors = true | ||
| c.SetArgs([]string{"--quitquitquit", "--admin-port", "9192", "my-project:my-region:my-instance"}) |
There was a problem hiding this comment.
Let's use 9193 or some other port to avoid conflicts with the test above.
cmd/root_test.go
Outdated
| @@ -1348,6 +1348,41 @@ func TestQuitQuitQuit(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestQuitQuitQuitHttpGet(t *testing.T) { | |||
enocom
reviewed
Sep 14, 2023
cmd/root_test.go
Outdated
| errCh <- err | ||
| }() | ||
|
|
||
| resp, err := tryDial("GET", "http://localhost:9192/quitquitquit") |
There was a problem hiding this comment.
Maybe we pull the port out as a constant to avoid this kind of mistake (9192 here, 9193 above)
enocom
approved these changes
Sep 14, 2023
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /quitquitquit endpoint used to return a 400 error when it received a request other than an HTTP POST. Now, it
will shut down the proxy if it receives either a GET or a POST request. This will make it possible for kubernetes
pod lifecycle handlers to gracefully signal the proxy to shut down.
Fixes #1946