Add -verbose flag to allow users to turn off verbose output #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of the library version of the proxy can swap in their own log implementations (or suppress logs in their own way). The binary distribution allows you to just turn off verbose flags.
|
LGTM |
yosatak
pushed a commit
to yosatak/cloud-sql-proxy
that referenced
this pull request
Feb 26, 2023
Update and refactor build info class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag defaults to true to keep old functionality (and to ease debugging when first setting it up), but people running the proxy in a server environment will likely want to turn off verbose output.
At some point we could consider setting the default to false.
Addresses #44 along with #100