Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quiet Flag #100

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Conversation

mykolasmith
Copy link
Contributor

@mykolasmith mykolasmith commented Jun 16, 2017

Hello,

This pull requests adds a -quiet flag. I am using cloud_sql_proxy in production on Google Container Engine, per these instructions, and the constant "Connection established" logging pollutes our log streams (and will eventually incur additional costs to Stackdriver Logging). Please consider merging this PR so that we may silence logging.

Thanks!

@mykolasmith
Copy link
Contributor Author

Partially addresses #44

@Carrotman42
Copy link
Contributor

Carrotman42 commented Jun 16, 2017

Hmm, I'm OK to accept this pull request because it addresses real problems people have raised, but this will basically make debugging any sort of errors impossible. Thus, my only request is add a single log line before turning off the output which says something along the lines of:

"WARNING: the -quiet flag has disabled all output; errors from connections will not be printed out which will likely make debugging difficult"

@mykolasmith
Copy link
Contributor Author

@Carrotman42 Carrotman42 merged commit 3aecf32 into GoogleCloudPlatform:master Jun 16, 2017
@Carrotman42
Copy link
Contributor

I appreciate the pull request!

Carrotman42 added a commit to Carrotman42/cloudsql-proxy that referenced this pull request Jun 16, 2017
@mykolasmith
Copy link
Contributor Author

@Carrotman42 when can we expect a v1.10 release w/ these changes?

@Carrotman42
Copy link
Contributor

I will release a new version either tomorrow or next Monday (June 26). Thank you for your patience.

@Carrotman42
Copy link
Contributor

Carrotman42 commented Jun 26, 2017

The new docker image is available at gcr.io/cloudsql-docker/gce-proxy:1.10, but unfortunately the internal site that we use to release the precompiled binary at https://dl.google.com/cloudsql/cloud_sql_proxy.linux.amd64 is down. Apologies for the delay, but once the internal site is back up I'll do an official release on this github site.

@Carrotman42
Copy link
Contributor

Carrotman42 commented Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants