Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: include example resource requests #434

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

serdarkkts
Copy link
Contributor

Fixes #433

Adds resource allocation configurations to the examples. The resource requests are configured with the side-car container default resource request values. Follows the approach on this PR

  • Tests pass
  • Appropriate changes to README are included in PR

@serdarkkts serdarkkts requested a review from a team as a code owner September 14, 2023 09:46
@google-cla
Copy link

google-cla bot commented Sep 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. We needed this example.

@hessjcg hessjcg enabled auto-merge (squash) September 14, 2023 17:45
@hessjcg hessjcg merged commit e4d0382 into GoogleCloudPlatform:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document resource requests
2 participants