Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document resource requests #433

Closed
serdarkkts opened this issue Sep 14, 2023 · 0 comments · Fixed by #434
Closed

Document resource requests #433

serdarkkts opened this issue Sep 14, 2023 · 0 comments · Fixed by #434
Assignees
@hessjcg

Comments

@serdarkkts
Copy link
Contributor

Expected Behavior

Users should have been informed that the auth-proxy side-car container is requesting 1 core CPU and 2Gi Memory by default. Additionally, examples can be provided of how to adjust these values.

Actual Behavior

The only way to understand the default requested resources is either diving through the operator code or inspecting the container resource allocation after deployment, which is not that convenient.

Steps to Reproduce the Problem

  1. Follow the instructions in the Quick Start Guide (or Examples) and deploy the operator and related resources
  2. Inspect the resource allocations

Specifications

A similar issue was created for cloud-sql-proxy and then users guided through the examples. I believe the same solution can be provided here as well.

  • Version: v1.1.0
  • Platform: -
@serdarkkts serdarkkts mentioned this issue Sep 14, 2023
Merged
2 tasks
hessjcg added a commit that referenced this issue Sep 14, 2023
@serdarkkts @hessjcg
doc: include example resource requests (#434)
e4d0382 
Adds resource allocation configurations to the examples. The resource requests are configured with the side-car container default resource request values. Follows the approach on this PR

Fixes #433

Co-authored-by: Jonathan Hess (he/him) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hessjcg hessjcg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: include example resource requests serdarkkts/cloud-sql-proxy-operator
2 participants
@serdarkkts @hessjcg