Tools: fix ValueError raised in check_names.py when overlong names are detected
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValueError may not be the correct type? Closes GoogleCloudPlatform#679
Closed
ludoo
approved these changes
Jun 16, 2022
27Bslash6
deleted the
fix--raise-an-error-in-check_names.py-if-lengths-exceeded
branch
ludoo
changed the title
ludoo
changed the title
ludoo
changed the title
ValueError raised in check_names.py when overlong names are detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueError may not be the correct type?
Will cause CI workflow to fail when lengths are exceeded, and will be used in a local pre-commit hook for automated validation.
Closes #679