Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_names.py should raise an error if names exceed lengths #679

Closed
27Bslash6 opened this issue Jun 16, 2022 · 0 comments · Fixed by #680
Closed

check_names.py should raise an error if names exceed lengths #679

27Bslash6 opened this issue Jun 16, 2022 · 0 comments · Fixed by #680

Comments

@27Bslash6
Copy link

For the name length check to fail in tests - CI, pre-commit - check_names.py should raise an error or the output may go unnoticed.
27Bslash6 pushed a commit to 27Bslash6/cloud-foundation-fabric that referenced this issue Jun 16, 2022
fix: Raise ValueError when check_names detects overlong names
35e5ffa 
ValueError may not be the correct type?

Closes GoogleCloudPlatform#679
@27Bslash6 27Bslash6 mentioned this issue Jun 16, 2022
Merged
lcaggio pushed a commit that referenced this issue Jun 17, 2022
@lcaggio
fix: Raise ValueError when check_names detects overlong names
f884fd4 
ValueError may not be the correct type?

Closes #679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@27Bslash6