Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example for a data playground Terraform setup #655

Merged
merged 21 commits into from
Jul 10, 2022
Merged

New example for a data playground Terraform setup #655

merged 21 commits into from
Jul 10, 2022

Conversation

aymanfarhat
Copy link
Member

A simple template for initialising a new project to be used as a data playground / data exploration project with the basics in place.

@lcaggio
Copy link
Collaborator

lcaggio commented May 19, 2022

Thanks for working on this! I think it is a great addition.

Feature to consider for this or a future version of this example:

  • support external Shared-VPC
  • Org policy useful for a secure data project (no external IP, OSlogin, ... Default: no Org policy enforced)
  • VPC-SC configuration useful for a secure data project (Project inside perimeter, protected services, ... Default: no Perimeters)
  • CMEK support

examples/data-solutions/data-playground/variables.tf Outdated Show resolved Hide resolved
examples/data-solutions/data-playground/variables.tf Outdated Show resolved Hide resolved
examples/data-solutions/data-playground/variables.tf Outdated Show resolved Hide resolved
@ludoo
Copy link
Collaborator

ludoo commented Jun 18, 2022

THis is great, thanks for the changes. As a last step, can you add a simple test like for the other examples, in the tests/examples folder?

@aymanfarhat
Copy link
Member Author

@ludoo Thanks for the feedback! I added a test folder as requested and addressed the comments mentioned by @lcaggio as well (reviewed them in a 1:1).

@ludoo
Copy link
Collaborator

ludoo commented Jun 25, 2022

Thanks for adding tests and implementing changes! The only things left before this can be merged are

  • a simple diagram that is inline with the style we use in the other examples
  • alphabetical ordering of variables :)

@aymanfarhat
Copy link
Member Author

Hello! I hope all is well. Just checking-in regarding this PR, is there anything else needed from my end? I see that it's approved but seems to be pending a merge. Thanks!

@ludoo ludoo merged commit 54d805d into GoogleCloudPlatform:master Jul 10, 2022
@aymanfarhat aymanfarhat deleted the example/data-playground branch July 10, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants