Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default location in tag value - cloud-run-v2 tags.tf #2755

Merged
merged 1 commit into from
Dec 9, 2024
Merged

remove default location in tag value - cloud-run-v2 tags.tf #2755

merged 1 commit into from
Dec 9, 2024

Conversation

Mattible
Copy link
Contributor

@Mattible Mattible commented Dec 9, 2024 •
edited
Loading

Fixes: #2754

The google_tags_location_tag_binding resource has a default to europe-west1 when it should use the same region/location as the cloud-run module is configured for

Changed to use the var.region instead of europe-west1

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@Mattible
remove default location in tag value - cloud-run-v2 tags.tf
b5f8c51 
The Parent resource has a default to europe-west1 when it should be for the resource block from where the cloud run actually is.

Changed to use the var.region instead
@google-cla Google CLA
Copy link

google-cla bot commented Dec 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Mattible
Copy link
Contributor Author

Mattible commented Dec 9, 2024

Signed CLA, apologies 😄

@juliocc
Copy link
Collaborator

juliocc commented Dec 9, 2024

Thanks for the fix! I'm still seeing the CLA as unsigned. Could you please double-check that it's been signed?

@Mattible
Copy link
Contributor Author

Mattible commented Dec 9, 2024 •
edited
Loading

Just re-ran through the prompts, it now shows a date signed instead of blank, so I will assume its now properly signed.

Sorry for the back and forth!

@ludoo ludoo merged commit 817df69 into GoogleCloudPlatform:master Dec 9, 2024
14 checks passed
steenblik pushed a commit to steenblik/cloud-foundation-fabric that referenced this pull request Dec 10, 2024
@Mattible @steenblik
remove default location in tag value - cloud-run-v2 tags.tf (GoogleCl…
8dbac47 
…oudPlatform#2755)

The Parent resource has a default to europe-west1 when it should be for the resource block from where the cloud run actually is.

Changed to use the var.region instead
steenblik added a commit that referenced this pull request Dec 10, 2024
@steenblik @ludoo
@LucaPrete @dependabot @juliocc @Mattible @rosmo @wiktorn @rune92
Add confidential compute support to google_dataproc_cluster in the da… (
90360c5 
#2736)

* Add confidential compute support to google_dataproc_cluster in the dataproc module

* fix parent id lookup for networking and security stages (#2744)

* Add optional automated MD5 generation in net-vlan-attachment module (#2745)

* Bump path-to-regexp and express in /blueprints/gke/binauthz/image (#2749)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.1 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.1...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add ability to autogenerate md5 keys in net-vpn-ha (#2748)

* Add ability to optionally generate MD5 secrets in VPN module

* Add ability to autogenerate MD5 keys in net-vpn-ha module

* restore missing output

* fix test counts

---------

Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>

* update changelog

* Bump path-to-regexp and express (#2752)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.1 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.1...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add support for routing mode to net-swp module (#2751)

Co-authored-by: Julio Castillo <[email protected]>

* remove default location in tag value - cloud-run-v2 tags.tf (#2755)

The Parent resource has a default to europe-west1 when it should be for the resource block from where the cloud run actually is.

Changed to use the var.region instead

* Add path_template_match and path_template_rewrite support to net-lb-app-ext (required for React apps for example).

* Add rest of load balancers.

* Add path_template_match and path_template_rewrite support to internal load balancers

* Add disk encyption key to the google_compute_instance_template - Sovereign support (#2750)

* add disk encyption key to the google_compute_instance_template

* add a condition to the kms_key_self_link

* use dynamic variable for disk_encryption_key

* remove the getpip from the repo

---------

Co-authored-by: Julio Castillo <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>

* Add support for password validation policy to cloudsql module (#2740)

* add support for password validation policy to cloudsql module

* fix defaults

* update changelog

* bump provider version constraint

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Julio Castillo <[email protected]>
Co-authored-by: Matthew Callinan <[email protected]>
Co-authored-by: Taneli Leppä <[email protected]>
Co-authored-by: Wiktor Niesiobędzki <[email protected]>
Co-authored-by: Kovács Dávid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud-Run-V2 module assumes the resource is in europe-west1 when applying tags
3 participants
@Mattible @juliocc @ludoo