Add ability to autogenerate md5 keys in net-vpn-ha #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sruffilli can we please check if we're fine with the module first? I assume some FAST tests might fail...If we're ok with it I'll then fix external tests failing (if any) |
LucaPrete
force-pushed
the
md5VpnTunnels
branch
from
3227ea9 to
9aa8eab
Compare
Why should FAST tests fail? You're adding an optional attribute... Ah, counts for the random resource :) I fixed your missing outputs, just update counts in all the failing tests and you should be good to go. |
ludoo
approved these changes
Dec 6, 2024
|
The output also changed…and the variables of the module itself take in
input those outputs… inception lol
Il giorno ven 6 dic 2024 alle 07:15 Ludovico Magnocavallo <
***@***.***> ha scritto:
… @sruffilli <https://github.com/sruffilli> can we please check if we're
fine with the module first? I assume some FAST tests might fail...If we're
ok with it I'll then fix external tests failing (if any)
Why should FAST tests fail? You're adding an optional attribute...
—
Reply to this email directly, view it on GitHub
<#2748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARY7UCAOWXJJWVYSN3TJLD2EE6HNAVCNFSM6AAAAABTCMW7FOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRSGIZDOMZQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
steenblik
pushed a commit
to steenblik/cloud-foundation-fabric
that referenced
this pull request
Dec 10, 2024
…rm#2748) * Add ability to optionally generate MD5 secrets in VPN module * Add ability to autogenerate MD5 keys in net-vpn-ha module * restore missing output * fix test counts --------- Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Ludovico Magnocavallo <[email protected]>
steenblik
added a commit
that referenced
this pull request
Dec 10, 2024
#2736) * Add confidential compute support to google_dataproc_cluster in the dataproc module * fix parent id lookup for networking and security stages (#2744) * Add optional automated MD5 generation in net-vlan-attachment module (#2745) * Bump path-to-regexp and express in /blueprints/gke/binauthz/image (#2749) Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.1 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add ability to autogenerate md5 keys in net-vpn-ha (#2748) * Add ability to optionally generate MD5 secrets in VPN module * Add ability to autogenerate MD5 keys in net-vpn-ha module * restore missing output * fix test counts --------- Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Ludovico Magnocavallo <[email protected]> * update changelog * Bump path-to-regexp and express (#2752) Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.1 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add support for routing mode to net-swp module (#2751) Co-authored-by: Julio Castillo <[email protected]> * remove default location in tag value - cloud-run-v2 tags.tf (#2755) The Parent resource has a default to europe-west1 when it should be for the resource block from where the cloud run actually is. Changed to use the var.region instead * Add path_template_match and path_template_rewrite support to net-lb-app-ext (required for React apps for example). * Add rest of load balancers. * Add path_template_match and path_template_rewrite support to internal load balancers * Add disk encyption key to the google_compute_instance_template - Sovereign support (#2750) * add disk encyption key to the google_compute_instance_template * add a condition to the kms_key_self_link * use dynamic variable for disk_encryption_key * remove the getpip from the repo --------- Co-authored-by: Julio Castillo <[email protected]> Co-authored-by: Ludovico Magnocavallo <[email protected]> * Add support for password validation policy to cloudsql module (#2740) * add support for password validation policy to cloudsql module * fix defaults * update changelog * bump provider version constraint --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ludovico Magnocavallo <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Julio Castillo <[email protected]> Co-authored-by: Matthew Callinan <[email protected]> Co-authored-by: Taneli Leppä <[email protected]> Co-authored-by: Wiktor Niesiobędzki <[email protected]> Co-authored-by: Kovács Dávid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py