Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcs & NFS mounts for cloud-run-v2 service #2686

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix gcs & NFS mounts for cloud-run-v2 service #2686

merged 2 commits into from
Nov 14, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Nov 14, 2024

closes #2684

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@ludoo
Copy link
Collaborator

ludoo commented Nov 14, 2024

Thanks for fixing my mess Wiktor :)

@wiktorn wiktorn force-pushed the wiktorn-cloudrun-gcs-mount-fix branch from a5b3055 to dd185f7 Compare November 14, 2024 11:03
@wiktorn wiktorn enabled auto-merge (rebase) November 14, 2024 11:03
@wiktorn wiktorn force-pushed the wiktorn-cloudrun-gcs-mount-fix branch from dd185f7 to 0177233 Compare November 14, 2024 12:13
@wiktorn wiktorn merged commit fe52a91 into master Nov 14, 2024
18 checks passed
@wiktorn wiktorn deleted the wiktorn-cloudrun-gcs-mount-fix branch November 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyricnz lyricnz lyricnz left review comments

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors when attempting to use GCS volumes in cloud-run-v2
3 participants
@wiktorn @ludoo @lyricnz