Errors when attempting to use GCS volumes in cloud-run-v2

[lyricnz]

Describe the bug
Cannot use the new support for GCS volumes in cloud-run-v2. Is it broken, or am I doing it wrong?

It was added:
#2638

Environment

output from `terraform -version`

❯ terraform -version
OpenTofu v1.8.4
on darwin_amd64
+ provider registry.opentofu.org/hashicorp/google v6.11.1
+ provider registry.opentofu.org/hashicorp/google-beta v6.11.1

output from `git rev-parse --short HEAD`

❯ git rev-parse --short HEAD
f1b074b5

To Reproduce
Steps to reproduce the behavior
Add a "volumes" stanza to a cloud-run-v2 module-resource in terraform:

  volumes = {
    xxx = {
      gcs = {
        bucket = "my-bucket-name"
        is_read_only = false
      }
    }
  }

Expected behavior
A clear and concise description of what you expected to happen.
Cloudrun to be created with this volume.

It works fine with the underlying provider:

# WORKS
resource "google_cloud_run_v2_service" "spam" {
  name = "dummy1"
  location     = "us-central1"
  launch_stage = "BETA"
  project = var.project_id

  template {
    execution_environment = "EXECUTION_ENVIRONMENT_GEN2"

    containers {
      image = "us-docker.pkg.dev/cloudrun/container/hello"
      volume_mounts {
        name       = "bucket"
        mount_path = "/var/www"
      }
    }

    volumes {
      name = "bucket"
      gcs {
        bucket = "my-bucket-name"
        read_only = false
      }
    }
  }
}

So problem seems to be in service.tf https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/modules/cloud-run-v2/service.tf#L208 which may be generating incorrect dynamic content?? I don't know how to debug this.

    dynamic "volumes" {
      for_each = var.volumes
      content {
        name = volumes.key
        dynamic "gcs" {
          for_each = volumes.value.gcs == null ? [] : [""]
          content {
            bucket    = volumes.value.bucket
            read_only = volumes.value.is_read_only
          }
        }
      }
    }
  }

Result
Terraform output and/or error messages

Plan: 1 to add, 1 to change, 1 to destroy.
╷
│ Error: Unsupported attribute
│
│   on ../../../modules/cloud-run-v2/service.tf line 211, in resource "google_cloud_run_v2_service" "service":
│  211:             bucket    = volumes.value.bucket
│     ├────────────────
│     │ volumes.value is object with 5 attributes
│
│ This object does not have an attribute named "bucket".
╵
╷
│ Error: Unsupported attribute
│
│   on ../../../modules/cloud-run-v2/service.tf line 212, in resource "google_cloud_run_v2_service" "service":
│  212:             read_only = volumes.value.is_read_only
│     ├────────────────
│     │ volumes.value is object with 5 attributes
│
│ This object does not have an attribute named "is_read_only".
╵```


**Additional context**
Add any other context about the problem here

[wiktorn]

This looks like a bug, let me take a look at it.

[lyricnz]

Should it be using each.key and each.value rather than volumes.key and volumes.value? #noob

[wiktorn]

Should it be using each.key and each.value rather than volumes.key and volumes.value? #noob

Close :-)

[lyricnz]

Cool! Will try that in the morning.

[lyricnz]

The fix (mostly) worked for me. Needed to add gen2_execution_environment = true also (which isn't in the example code)

[lyricnz]

Thank you!