Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codespell to pre-commit #2643

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Add codespell to pre-commit #2643

merged 4 commits into from
Oct 30, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Oct 29, 2024

And disable tflint on fast, as they require non-trival arguments.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn force-pushed the wiktorn-spellcheck branch from 84a474b to aea5a08 Compare October 30, 2024 08:18
@juliocc
Copy link
Collaborator

juliocc commented Oct 30, 2024

Nice.

Just one comment: I'm not sure if you should spellcheck the changelog since it's autogenerated from PR titles.

@wiktorn wiktorn force-pushed the wiktorn-spellcheck branch from aea5a08 to b095195 Compare October 30, 2024 09:16
@wiktorn wiktorn enabled auto-merge (rebase) October 30, 2024 09:19
@wiktorn wiktorn merged commit dafb8d2 into master Oct 30, 2024
18 checks passed
@wiktorn wiktorn deleted the wiktorn-spellcheck branch October 30, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:blueprints on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @juliocc