Codespell / whitespace fixes

.pre-commit-config.yaml

@@ -107,4 +107,4 @@ repos:
   rev: v2.2.6
   hooks:
   - id: codespell
-    exclude: requirements.txt$|excalidraw$
+    exclude: (requirements.txt$|excalidraw$|package-lock\.json$|go\.sum$)

CHANGELOG.md

@@ -100,7 +100,7 @@ All notable changes to this project will be documented in this file.
 - [[#2497](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2497)] Net vpc firewall factory schema ([ludoo](https://github.com/ludoo)) <!-- 2024-08-10 13:04:50+00:00 -->
 - [[#2494](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2494)] Additional module schemas ([ludoo](https://github.com/ludoo)) <!-- 2024-08-09 13:58:06+00:00 -->
 - [[#2491](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2491)] Organization module factory schemas ([ludoo](https://github.com/ludoo)) <!-- 2024-08-09 10:22:57+00:00 -->
-- [[#2483](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2483)] Add boostrap output with log destination ids ([juliocc](https://github.com/juliocc)) <!-- 2024-08-08 14:23:38+00:00 -->
+- [[#2483](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2483)] Add bootstrap output with log destination ids ([juliocc](https://github.com/juliocc)) <!-- 2024-08-08 14:23:38+00:00 -->
 - [[#2482](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2482)] [FAST] Rename netsec stage to nsec ([LucaPrete](https://github.com/LucaPrete)) <!-- 2024-08-08 12:30:09+00:00 -->
 - [[#2477](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2477)] VPC-SC factory JSON Schemas ([ludoo](https://github.com/ludoo)) <!-- 2024-08-07 12:09:38+00:00 -->
 - [[#2471](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2471)] Rename 1-vpc-sc stage to 1-vpcsc ([juliocc](https://github.com/juliocc)) <!-- 2024-08-06 11:21:55+00:00 -->
@@ -475,7 +475,7 @@ All notable changes to this project will be documented in this file.
 - [[#2185](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2185)] Fix failing e2e tests for Cloud Run CMEK ([wiktorn](https://github.com/wiktorn)) <!-- 2024-03-28 14:02:56+00:00 -->
 - [[#2182](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2182)] **incompatible change:** Fix default nodepool defaults in gke standard module ([ludoo](https://github.com/ludoo)) <!-- 2024-03-28 10:22:15+00:00 -->
 - [[#2177](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2177)] add cmek option for cloud_run_v2 ([SalehElnagarSecurrency](https://github.com/SalehElnagarSecurrency)) <!-- 2024-03-27 09:15:03+00:00 -->
-- [[#2175](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2175)] feat(gke-cluster-standard): Set optionnal `default_node_pool` configuration ([anthonyhaussman](https://github.com/anthonyhaussman)) <!-- 2024-03-26 17:05:35+00:00 -->
+- [[#2175](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2175)] feat(gke-cluster-standard): Set optional `default_node_pool` configuration ([anthonyhaussman](https://github.com/anthonyhaussman)) <!-- 2024-03-26 17:05:35+00:00 -->
 - [[#2174](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2174)] Bump provider version to 5.18 to fix non-empty plan for google_notebooks_instance ([wiktorn](https://github.com/wiktorn)) <!-- 2024-03-25 18:57:14+00:00 -->
 - [[#2171](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2171)] **incompatible change:** Fix subnet configuration in cloud nat module ([ludoo](https://github.com/ludoo)) <!-- 2024-03-22 14:59:02+00:00 -->
 - [[#2170](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2170)] Support optional secondary ranges in net-cloudnat module ([ludoo](https://github.com/ludoo)) <!-- 2024-03-22 11:10:48+00:00 -->
@@ -635,7 +635,7 @@ All notable changes to this project will be documented in this file.
 - [[#2004](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/2004)] **incompatible change:** Remove default region for Cloud Function and Cloud Run ([wiktorn](https://github.com/wiktorn)) <!-- 2024-01-24 10:23:40+00:00 -->
 - [[#1977](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1977)] Add example to FAST GKE stage, streamline GKE Hub module variables and usage ([ludoo](https://github.com/ludoo)) <!-- 2024-01-20 10:06:38+00:00 -->
 - [[#1992](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1992)] Fix Data platform foundation ([lcaggio](https://github.com/lcaggio)) <!-- 2024-01-20 07:49:47+00:00 -->
-- [[#1976](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1976)] Network dashboard - fixing 2 bugs: overriden variable and page token … ([aurelienlegrand](https://github.com/aurelienlegrand)) <!-- 2024-01-15 13:28:17+00:00 -->
+- [[#1976](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1976)] Network dashboard - fixing 2 bugs: overridden variable and page token … ([aurelienlegrand](https://github.com/aurelienlegrand)) <!-- 2024-01-15 13:28:17+00:00 -->
 - [[#1819](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1819)] Serverless networking program ([juliodiez](https://github.com/juliodiez)) <!-- 2024-01-05 21:03:34+00:00 -->
 - [[#1952](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1952)] Composer blueprints improvements ([wiktorn](https://github.com/wiktorn)) <!-- 2023-12-29 11:09:16+00:00 -->
 - [[#1939](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1939)] Networking Sandbox Blueprint ([sruffilli](https://github.com/sruffilli)) <!-- 2023-12-21 16:50:39+00:00 -->
@@ -762,7 +762,7 @@ All notable changes to this project will be documented in this file.
 - [[#1914](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1914)] Allow per-module terraform fixtures ([juliocc](https://github.com/juliocc)) <!-- 2023-12-29 09:43:44+00:00 -->
 - [[#1953](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1953)] Fix variable region ([andybubu](https://github.com/andybubu)) <!-- 2023-12-28 14:04:15+00:00 -->
 - [[#1950](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1950)] Add version check ([wiktorn](https://github.com/wiktorn)) <!-- 2023-12-27 07:40:23+00:00 -->
-- [[#1937](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1937)] Fix always succeding test ([wiktorn](https://github.com/wiktorn)) <!-- 2023-12-21 11:01:08+00:00 -->
+- [[#1937](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1937)] Fix always succeeding test ([wiktorn](https://github.com/wiktorn)) <!-- 2023-12-21 11:01:08+00:00 -->
 - [[#1932](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1932)] Simplify organization tags.tf locals ([juliocc](https://github.com/juliocc)) <!-- 2023-12-18 16:09:22+00:00 -->
 - [[#1890](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1890)] Use TFTEST_E2E_ instead of TF_VAR variables ([wiktorn](https://github.com/wiktorn)) <!-- 2023-11-30 19:03:59+00:00 -->
 
@@ -870,7 +870,7 @@ All notable changes to this project will be documented in this file.
 - [[#1804](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1804)] compute-vm: remove old todo ([LucaPrete](https://github.com/LucaPrete)) <!-- 2023-10-24 10:45:54+00:00 -->
 - [[#1803](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1803)] use the repository format in the image_path output ([Tutuchan](https://github.com/Tutuchan)) <!-- 2023-10-24 10:24:53+00:00 -->
 - [[#1801](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1801)] Fix Internal App LB serverless NEG backend example ([juliocc](https://github.com/juliocc)) <!-- 2023-10-24 07:25:44+00:00 -->
-- [[#1795](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1795)] Allow users to optonally specify address names ([LucaPrete](https://github.com/LucaPrete)) <!-- 2023-10-23 15:17:07+00:00 -->
+- [[#1795](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1795)] Allow users to optionally specify address names ([LucaPrete](https://github.com/LucaPrete)) <!-- 2023-10-23 15:17:07+00:00 -->
 - [[#1792](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1792)] Removed unnecessary try statements from apigee module outputs ([apichick](https://github.com/apichick)) <!-- 2023-10-22 16:13:13+00:00 -->
 - [[#1786](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1786)] net-lb-ext: add support for multiple forwarding rules (IPs) and dual-stack (IPv4/IPv6) ([LucaPrete](https://github.com/LucaPrete)) <!-- 2023-10-21 16:19:18+00:00 -->
 - [[#1782](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1782)] Add upper cap to versions, update copyright notices ([sruffilli](https://github.com/sruffilli)) <!-- 2023-10-20 16:17:48+00:00 -->
@@ -1148,7 +1148,7 @@ All notable changes to this project will be documented in this file.
 - [[#1510](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1510)] **incompatible change:** Refactoring of dns module ([apichick](https://github.com/apichick)) <!-- 2023-07-19 11:13:41+00:00 -->
 - [[#1509](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1509)] Add output to org module with custom constraint details and depends_on ([juliocc](https://github.com/juliocc)) <!-- 2023-07-18 08:24:39+00:00 -->
 - [[#1503](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1503)] Move IAM grant to function level for trigger SA ([wiktorn](https://github.com/wiktorn)) <!-- 2023-07-12 14:19:35+00:00 -->
-- [[#1479](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1479)] Update ncc-spoke-ra module to explicity request ncc hub id when referencing existing hubs ([simonebruzzechesse](https://github.com/simonebruzzechesse)) <!-- 2023-07-10 14:18:43+00:00 -->
+- [[#1479](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1479)] Update ncc-spoke-ra module to explicitly request ncc hub id when referencing existing hubs ([simonebruzzechesse](https://github.com/simonebruzzechesse)) <!-- 2023-07-10 14:18:43+00:00 -->
 - [[#1499](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1499)] Add support for custom description in net-address ([simonebruzzechesse](https://github.com/simonebruzzechesse)) <!-- 2023-07-10 11:04:54+00:00 -->
 - [[#1497](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1497)] **incompatible change:** Implement proper support for data access logs in resource manager modules ([ludoo](https://github.com/ludoo)) <!-- 2023-07-10 08:08:03+00:00 -->
 

blueprints/apigee/hybrid-gke/ansible/roles/apigee-hybrid/tasks/main.yaml

@@ -105,23 +105,23 @@
 
 - name: Create certificate and private key
   shell: >
-    openssl req  \ 
+    openssl req  \
     -nodes \
     -new \
     -x509 \
     -keyout ~/hybrid-files/certs/server.key \
     -out ~/hybrid-files/certs/server.crt \
-    -subj "/CN=apigee.com' \ 
+    -subj "/CN=apigee.com' \
     -addext "subjectAltName={{ hostnames | map('regex_replace', '^', 'DNS:') | join(',') }}""
     -days 3650
 
-- name: Read certificate 
-  slurp: 
+- name: Read certificate
+  slurp:
     src: ~/hybrid-files/certs/server.crt
   register: certificate_output
 
-- name: Read private ket 
-  slurp: 
+- name: Read private key
+  slurp:
     src: ~/hybrid-files/certs/server.key
   register: privatekey_output
 
@@ -232,10 +232,10 @@
       type: Ready
       status: True
 
-- name: 
+- name:
   kubernetes.core.k8s:
-    state: present   
-    definition: 
+    state: present
+    definition:
       apiVersion: apigee.cloud.google.com/v1alpha1
       kind: ApigeeRoute
       metadata:
@@ -252,24 +252,24 @@
             mode: SIMPLE
         selector:
           app: apigee-ingressgateway
-        enableNonSniClient: true 
+        enableNonSniClient: true
 
 - name: Create google-managed certificate
   kubernetes.core.k8s:
-    state: present   
-    definition: 
+    state: present
+    definition:
       apiVersion: networking.gke.io/v1
       kind: ManagedCertificate
       metadata:
         name: "apigee-cert-hybrid"
         namespace: apigee
       spec:
         domains: "{{ hostnames }}"
-      
+
 - name: Create backend config
   kubernetes.core.k8s:
-    state: present  
-    definition:  
+    state: present
+    definition:
       apiVersion: cloud.google.com/v1
       kind: BackendConfig
       metadata:
@@ -330,4 +330,4 @@
           service:
             name: apigee-ingressgateway-hybrid
             port:
-              number: 443    
+              number: 443

blueprints/cloud-operations/network-quota-monitoring/src/plugins/series-firewall-rules.py

@@ -33,7 +33,7 @@ def timeseries(resources):
   # return a single descriptor for network as we don't have limits
   yield MetricDescriptor(f'network/firewall_rules_used',
                          'Firewall rules used per network', ('project', 'name'))
-  # return used/vailable/ratio descriptors for project
+  # return used/available/ratio descriptors for project
   for dtype, name in DESCRIPTOR_ATTRS.items():
     yield MetricDescriptor(f'project/{dtype}', name, ('project',),
                            dtype.endswith('ratio'))

blueprints/data-solutions/bq-ml/demo/README.md

@@ -27,7 +27,7 @@ In this tutorial we will make use of the following main components:
 	- standard: to create a view which contains the model features and the target variable
 	- ML: to train, evaluate and make batch predictions
 - Vertex AI:
-	- Pipeline: to define a configurable and re-usable set of steps to train and evaluate a BQML model
+	- Pipeline: to define a configurable and reusable set of steps to train and evaluate a BQML model
 	- Experiment: to keep track of all the trainings done via the Pipeline
 	- Model Registry: to keep track of the trained versions of a specific model
 	- Endpoint: to serve the model via API
@@ -37,4 +37,4 @@ In this tutorial we will make use of the following main components:
 
 1. Access the Vertex AI Workbench
 2. clone this repository
-2. run the [`bmql_pipeline.ipynb`](bmql_pipeline.ipynb) Jupyter Notebook
+2. run the [`bmql_pipeline.ipynb`](bmql_pipeline.ipynb) Jupyter Notebook

blueprints/data-solutions/bq-ml/demo/bmql_pipeline.ipynb

@@ -435,7 +435,7 @@
     "# Conclusions\n",
     "\n",
     "Thanks to this tutorial we were able to:\n",
-    "- Define a re-usable Vertex AI pipeline to train and evaluate BQ ML models\n",
+    "- Define a reusable Vertex AI pipeline to train and evaluate BQ ML models\n",
     "- Use a Vertex AI Experiment to keep track of multiple trainings for the same model with different parameters (in this case a different split for train/test data)\n",
     "- Deploy the preferred model on a Vertex AI managed Endpoint in order to serve the model for real-time use cases via API\n",
     "- Make batch prediction via Big Query and see what are the top 5 features which influenced the algorithm output"

blueprints/data-solutions/sqlserver-alwayson/scripts/windows-startup-witness.ps1

@@ -22,11 +22,11 @@ $BackupPath = "C:\Backup"
 
 if (-not(Test-Path -Path $InitialSetup -PathType Leaf)) {
   Write-Output "Performing initial setup for witness"
-  
+
   All-Instances-Ready
 
   if (-not(Test-Path -Path $WitnessPath -PathType Container)) {
-    Write-Log "Creatin witness directory $WitnessPath and share..."
+    Write-Log "Creating witness directory $WitnessPath and share..."
     New-Item $WitnessPath -type directory
     New-SmbShare -Name QWitness -Path $WitnessPath -Description "SQL File Share Quorum Witness" -FullAccess ${node_netbios_1}$,${node_netbios_2}$
     Start-Sleep -s 10
@@ -40,7 +40,7 @@ if (-not(Test-Path -Path $InitialSetup -PathType Leaf)) {
   }
 
   icacls $WitnessPath /t /grant '${node_netbios_1}$:(OI)(CI)(M)'
-  icacls $WitnessPath /t /grant '${node_netbios_2}$:(OI)(CI)(M)'  
+  icacls $WitnessPath /t /grant '${node_netbios_2}$:(OI)(CI)(M)'
 
   Cluster-In-Domain
 
@@ -51,4 +51,4 @@ if (-not(Test-Path -Path $InitialSetup -PathType Leaf)) {
 
   New-Item "$WitnessPath\SetupDone.txt"
   New-Item $InitialSetup
-}
+}

blueprints/gke/patterns/autopilot-cluster/README.md

@@ -59,7 +59,7 @@ This blueprint by default deploys an Autopilot cluster with private nodes and pr
 - Use namespaces to restrict access to cluster resources: this blueprint deploys the underlying infrastructure, namespace handling is left to applications.
 
 ### Networking
-- Create a custom mode VPC: this blueprint can optinally deploy a new custom VPC with a single subnet. Otherwise, an existing VPC and subnet can be used.
+- Create a custom mode VPC: this blueprint can optionally deploy a new custom VPC with a single subnet. Otherwise, an existing VPC and subnet can be used.
 - Create a proxy-only subnet: the `vpc_create` variable allows the creation of proxy only subnet, if needed.
 - Configure Shared VPC: by default a new VPC is created within the project, but a Shared VPC can be used when the blueprint handles project creation.
 - Connect the cluster's VPC network to an on-premises network: skipped, out of scope for this blueprint

blueprints/networking/ha-vpn-over-interconnect/README.md

@@ -4,7 +4,7 @@ This blueprint creates a complete HA VPN over Interconnect setup, which leverage
 
 This blueprint supports Dedicated Interconnect and Partner Interconnect.
 
-In case of Partner Interconnect only partial apply is possible at first, which creates the VLAN Attachments. Only once the partner connection is established it is possible to deploy HA VPN Gateway and all dependant resources. 
+In case of Partner Interconnect only partial apply is possible at first, which creates the VLAN Attachments. Only once the partner connection is established it is possible to deploy HA VPN Gateway and all dependent resources.
 
 ## Managed resources and services
 

blueprints/networking/hub-and-spoke-peering/README.md

@@ -1,5 +1,5 @@
 # Hub and spoke via peering VPC architecture
 
-This blueprint was deprecated in the v30.0.0 release, as it's been supersed by the [FAST networking stage](../../../fast/stages/2-networking-a-simple/) that deploys a hub and spoke network via peering (or optionally via VPN), which is regularly updated and can also be deployed as a standalone blueprint.
+This blueprint was deprecated in the v30.0.0 release, as it's been superseded by the [FAST networking stage](../../../fast/stages/2-networking-a-simple/) that deploys a hub and spoke network via peering (or optionally via VPN), which is regularly updated and can also be deployed as a standalone blueprint.
 
 If you still need to access the legacy blueprint, you can check it out using our [v29.0.0 tag](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/tree/v29.0.0/blueprints/networking/hub-and-spoke-peering).

blueprints/networking/hub-and-spoke-vpn/README.md

@@ -1,5 +1,5 @@
 # Hub and spoke via VPN VPC architecture
 
-This blueprint was deprecated in the v30.0.0 release, as it's been supersed by the [FAST networking stage](../../../fast/stages/2-networking-a-simple/) that deploys a hub and spoke network via VPN (or optionally via peering), which is regularly updated and can also be deployed as a standalone blueprint.
+This blueprint was deprecated in the v30.0.0 release, as it's been superseded by the [FAST networking stage](../../../fast/stages/2-networking-a-simple/) that deploys a hub and spoke network via VPN (or optionally via peering), which is regularly updated and can also be deployed as a standalone blueprint.
 
 If you still need to access the legacy blueprint, you can check it out using our [v29.0.0 tag](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/tree/v29.0.0/blueprints/networking/hub-and-spoke-vpn).

fast/plugins/2-networking-serverless-connector/README.md

@@ -10,7 +10,7 @@ This plugin does not manage
 The plugin only requires a specific configuration if the defaults it uses need to be changed:
 
 - the connector-specific subnets default to the `10.255.255.0` range
-- the machine type, number of instances and thoughput use the API defaults
+- the machine type, number of instances and throughput use the API defaults
 
 To enable the plugin, simply copy or link its files in the networking stage.
 

fast/stages/0-bootstrap/identity-providers.tf

@@ -73,7 +73,7 @@ resource "google_iam_workload_identity_pool_provider" "default" {
   oidc {
     # Setting an empty list configures allowed_audiences to the url of the provider
     allowed_audiences = each.value.custom_settings.audiences
-    # If users don't provide an issuer_uri, we set the public one for the platform choosed.
+    # If users don't provide an issuer_uri, we set the public one for the platform chosen.
     issuer_uri = (
       each.value.custom_settings.issuer_uri != null
       ? each.value.custom_settings.issuer_uri