Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send_secondary_ip_range_if_empty=true to google_compute_subnetwork #2537

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add send_secondary_ip_range_if_empty=true to google_compute_subnetwork #2537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f9e670
Add send_secondary_ip_range_if_empty=true to google_compute_subnetwork
sruffilli Aug 28, 2024
9c13ca0
Merge branch 'master' into sruffilli/net-vpc-subnet-fix
ludoo Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions modules/net-vpc/subnets.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,24 +159,14 @@ resource "google_compute_subnetwork" "subnetwork" {
ipv6_access_type = (
try(each.value.ipv6, null) != null ? each.value.ipv6.access_type : null
)
# private_ipv6_google_access = try(each.value.ipv6.enable_private_access, null)
private_ipv6_google_access = try(each.value.ipv6.enable_private_access, null)
send_secondary_ip_range_if_empty = true

dynamic "secondary_ip_range" {
for_each = each.value.secondary_ip_ranges == null ? {} : each.value.secondary_ip_ranges
content {
range_name = secondary_ip_range.key
ip_cidr_range = secondary_ip_range.value
# TODO(sruffilli): Provider 5.29.1 disabled reserved_internal_range because of a bug.
# Revert to the following once fixed.
# ip_cidr_range = (
# startswith(secondary_ip_range.value, "networkconnectivity.googleapis.com")
# ? null
# : secondary_ip_range.value
# )
# reserved_internal_range = (
# startswith(secondary_ip_range.value, "networkconnectivity.googleapis.com")
# ? secondary_ip_range.value
# : null
# )
}
}
dynamic "log_config" {
Expand Down