Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send_secondary_ip_range_if_empty=true to google_compute_subnetwork #2537

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

sruffilli
Copy link
Collaborator

@sruffilli sruffilli commented Aug 28, 2024

Fixes #2527.
Default the newly available send_secondary_ip_range_if_empty for compute_subnetwork to true on net-vpc

send_secondary_ip_range_if_empty - (Optional) Controls the removal behavior of secondary_ip_range. When false, removing secondary_ip_range from config will not produce a diff as the provider will default to the API's value. When true, the provider will treat removing secondary_ip_range as sending an empty list of secondary IP ranges to the API. Defaults to false.

@sruffilli sruffilli marked this pull request as ready for review August 28, 2024 13:47
@sruffilli sruffilli enabled auto-merge (squash) August 28, 2024 13:48
@sruffilli sruffilli merged commit 09de7d6 into master Aug 28, 2024
18 checks passed
@sruffilli sruffilli deleted the sruffilli/net-vpc-subnet-fix branch August 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement send_secondary_ip_range_if_empty for net-vpc
2 participants