Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for Cloud Functions and fix perma-diff #2413

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Add E2E tests for Cloud Functions and fix perma-diff #2413

merged 3 commits into from
Jul 8, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Jul 8, 2024 •
edited
Loading

Closes #2403 and adds end-to-end tests for CFv1 and CFv2

Incompatible change

  • modules/cloud-function-v2 - environment variables for build are now taken from separate variable - build_environment_variables

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@github-actions github-actions bot added on:tools New or changed tool on:modules labels Jul 8, 2024
ludoo
ludoo approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Wiktor!

@wiktorn wiktorn added the incompatible change Pull request that breaks compatibility with previous version label Jul 8, 2024
@wiktorn wiktorn merged commit 01904c3 into master Jul 8, 2024
17 checks passed
@wiktorn wiktorn deleted the wiktorn-cff-variables branch July 8, 2024 14:14
@wiktorn wiktorn mentioned this pull request Jul 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
incompatible change Pull request that breaks compatibility with previous version on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split build and service environment variables in cloud functions modules
2 participants
@wiktorn @ludoo