Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split build and service environment variables in cloud functions modules #2403

Closed
ludoo opened this issue Jul 1, 2024 · 0 comments · Fixed by #2413
Closed

Split build and service environment variables in cloud functions modules #2403

ludoo opened this issue Jul 1, 2024 · 0 comments · Fixed by #2413
Assignees

Comments

@ludoo
Copy link
Collaborator

ludoo commented Jul 1, 2024

We always took a shortcut in the CF modules with environment variables, when we used a single variable to define both build and service variables. Now this (which was not entirely ok to start with) generates a permadiff with the introduction of log execution.

We need to change the variable so it has optional build and service members, and default service_config.environment_variables["LOG_EXECUTION_ID"] to avoid a permadiff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants