Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added expire_time option to the secret-manager module #2373

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Added expire_time option to the secret-manager module #2373

merged 3 commits into from
Jun 23, 2024

Conversation

deanosaurx
Copy link
Contributor

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@deanosaurx deanosaurx mentioned this pull request Jun 23, 2024
Closed
@deanosaurx
Copy link
Contributor Author

Had no idea there is a check for alphabetical order lol.
Fixed.

@juliocc juliocc merged commit 270f61a into GoogleCloudPlatform:master Jun 23, 2024
9 checks passed
@deanosaurx deanosaurx deleted the patch-1 branch June 23, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanosaurx @juliocc