Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for expiry_time for secret-manager module #2367

Closed
fulyagonultas opened this issue Jun 18, 2024 · 2 comments
Closed

Add support for expiry_time for secret-manager module #2367

fulyagonultas opened this issue Jun 18, 2024 · 2 comments

Comments

@fulyagonultas
Copy link
Contributor

Include the ´expiry_time´ for secrets in the secret-manager module. Currently, it does not support adding expiration for secret.

https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/tree/master/modules/secret-manager

expire_time - (Optional) Timestamp in UTC when the Secret is scheduled to expire. This is always provided on output, regardless of what was sent on input. A timestamp in RFC3339 UTC "Zulu" format, with nanosecond resolution and up to nine fractional digits. Examples: "2014-10-02T15:01:23Z" and "2014-10-02T15:01:23.045123456Z". Only one of expire_time or ttl can be provided.

@deanosaurx
Copy link
Contributor

I just made a PR to address this issue - #2373

@juliocc
Copy link
Collaborator

juliocc commented Jun 23, 2024

Fixed with #2373

@juliocc juliocc closed this as completed Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants