Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove default value for region/location from modules #2067

Closed
wants to merge 10 commits into from
Closed

Fix: Remove default value for region/location from modules #2067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b08c2dc
Removed default value for region/location from modules
imVipul3000 Feb 11, 2024
beb20cd
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
3d2bd6e
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
7f54a19
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
992d766
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
59c2372
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
b16e76b
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
3c6ef4f
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
2f43151
Remove default value for region/location from modules
imVipul3000 Feb 11, 2024
c3066c0
Merge branch 'master' into master
ludoo Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/bigquery-dataset/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ variable "labels" {
variable "location" {
description = "Dataset location."
type = string
default = "EU"
default = null
}

variable "materialized_views" {
Expand Down
2 changes: 1 addition & 1 deletion modules/container-registry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This module simplifies the creation of GCS buckets used by Google Container Regi
module "container_registry" {
source = "./fabric/modules/container-registry"
project_id = "myproject"
location = "EU"
location = var.region
iam = {
"roles/storage.admin" = ["group:[email protected]"]
}
Expand Down
2 changes: 1 addition & 1 deletion modules/container-registry/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ variable "iam" {
variable "location" {
description = "Registry location. Can be US, EU, ASIA or empty."
type = string
default = ""
default = null
}

variable "project_id" {
Expand Down
2 changes: 1 addition & 1 deletion modules/data-catalog-policy-tag/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ variable "description" {
variable "location" {
description = "Data Catalog Taxonomy location."
type = string
default = "eu"
default = null
}

variable "name" {
Expand Down
2 changes: 1 addition & 1 deletion modules/gcs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module "kms" {
source = "./fabric/modules/kms"
project_id = var.project_id
keyring = {
location = "europe" # location of the KMS must match location of the bucket
location = "var.location" # location of the KMS must match location of the bucket
name = "test"
}
keys = {
Expand Down
2 changes: 1 addition & 1 deletion modules/gcs/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ variable "lifecycle_rules" {
variable "location" {
description = "Bucket location."
type = string
default = "EU"
default = null
}

variable "logging_config" {
Expand Down
Loading