Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove default value for region/location from modules #2067

Closed
wants to merge 10 commits into from

Conversation

imVipul3000
Copy link

PR for Issue #2003

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • [X} Made sure all relevant tests pass

@wiktorn
Copy link
Collaborator

wiktorn commented Feb 11, 2024

Thank you for picking up this @imVipul3000. If we will have default = null as you propose, we will offload that decision to provider or API. I prefer to ask the user for explicit decision here and remove the default = ... lines at all.

@ludoo
Copy link
Collaborator

ludoo commented Feb 18, 2024

Closing this as it's become stale, feel free to reopen once the suggestions have been implemented.

@ludoo ludoo closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants