Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resource-level IAM interface for kms and pubsub modules #1684

Merged
merged 9 commits into from
Sep 17, 2023
Merged

Update resource-level IAM interface for kms and pubsub modules #1684

merged 9 commits into from
Sep 17, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Sep 15, 2023 •
edited
Loading

Update the following modules to use new-style IAM fields:

  • modules/kms
  • modules/pubsub

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc changed the title Upadte resource-level IAM interface for kms and pubsub modules Update resource-level IAM interface for kms and pubsub modules Sep 15, 2023
@juliocc juliocc force-pushed the jccb/more-iam branch 2 times, most recently from 9b874d8 to 68c59be Compare September 16, 2023 17:58
@juliocc juliocc linked an issue Sep 16, 2023 that may be closed by this pull request
Refactor pubsub module #1673
Closed
@juliocc juliocc added the incompatible change Pull request that breaks compatibility with previous version label Sep 16, 2023
@juliocc juliocc marked this pull request as ready for review September 17, 2023 08:13
@juliocc juliocc requested a review from ludoo September 17, 2023 08:13
@juliocc juliocc merged commit 0c578c0 into master Sep 17, 2023
13 checks passed
@juliocc juliocc deleted the jccb/more-iam branch September 17, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor pubsub module
2 participants
@juliocc @ludoo