Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pubsub module #1673

Closed
juliocc opened this issue Sep 13, 2023 · 0 comments · Fixed by #1684
Closed

Refactor pubsub module #1673

juliocc opened this issue Sep 13, 2023 · 0 comments · Fixed by #1684

Comments

@juliocc
Copy link
Collaborator

juliocc commented Sep 13, 2023

Rewrite and simplify the pubsub module using modern terraform features like optional, defaults, etc.

Some things to keep in mind:

  • should merge all the *_subscription_configs into a single subscriptions variable.
  • remove the defaults variable and user optionals + default values.
  • align IAM with the new repo-wide design.
  • Add support for missing features.
@juliocc juliocc linked a pull request Sep 16, 2023 that will close this issue
Update resource-level IAM interface for kms and pubsub modules #1684
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@juliocc