Refactor firewall policy module #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
approved these changes
Aug 8, 2023
juliocc
added
the
incompatible change
juliocc
force-pushed
the
ludo/issue-1570
branch
from
0498749 to
3c4febe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first part of the plan described in #1570 by refactoring the module so it manages all three firewall policy types, optional attachments, and a rule factory.
The implementation of rules is a bit convoluted to work around Terraform's type checks / conditionals making a mess of identically typed structures.
Leaving it as draft so we can look at it and decide if this is the way forward.