-
Notifications
You must be signed in to change notification settings - Fork 910
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor firewall policy module (#1576)
* refactor module interface * hierarchical attachment and example * hierarchical rules and TODO * split rules resources * additional fields * keep using a single resource for rules * factory * factory test * boilerplate * Prefix ingress and egress rule ids * Tests for other firewall policy types * Fix rule id and names --------- Co-authored-by: Julio Castillo <[email protected]>
- Loading branch information
Showing
12 changed files
with
1,132 additions
and
167 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| /** | ||
| * Copyright 2023 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| locals { | ||
| _factory_egress_rules = ( | ||
| var.rules_factory_config.egress_rules_file_path == null | ||
| ? {} | ||
| : yamldecode(file(var.rules_factory_config.egress_rules_file_path)) | ||
| ) | ||
| _factory_ingress_rules = ( | ||
| var.rules_factory_config.ingress_rules_file_path == null | ||
| ? {} | ||
| : yamldecode(file(var.rules_factory_config.ingress_rules_file_path)) | ||
| ) | ||
| factory_cidrs = ( | ||
| var.rules_factory_config.cidr_file_path == null | ||
| ? {} | ||
| : yamldecode(file(var.rules_factory_config.cidr_file_path)) | ||
| ) | ||
| factory_egress_rules = { | ||
| for k, v in local._factory_egress_rules : "ingress/${k}" => { | ||
| action = "deny" | ||
| direction = "EGRESS" | ||
| priority = v.priority | ||
| description = lookup(v, "description", null) | ||
| disabled = lookup(v, "disabled", false) | ||
| enable_logging = lookup(v, "enable_logging", null) | ||
| target_service_accounts = lookup(v, "target_service_accounts", null) | ||
| target_tags = lookup(v, "target_tags", null) | ||
| match = { | ||
| address_groups = lookup(v.match, "address_groups", null) | ||
| fqdns = lookup(v.match, "fqdns", null) | ||
| region_codes = lookup(v.match, "region_codes", null) | ||
| threat_intelligences = lookup(v.match, "threat_intelligences", null) | ||
| destination_ranges = ( | ||
| lookup(v.match, "destination_ranges", null) == null | ||
| ? null | ||
| : flatten([ | ||
| for r in v.match.destination_ranges : | ||
| try(local.factory_cidrs[r], r) | ||
| ]) | ||
| ) | ||
| source_ranges = ( | ||
| lookup(v.match, "source_ranges", null) == null | ||
| ? null | ||
| : flatten([ | ||
| for r in v.match.source_ranges : | ||
| try(local.factory_cidrs[r], r) | ||
| ]) | ||
| ) | ||
| source_tags = lookup(v.match, "source_tags", null) | ||
| layer4_configs = ( | ||
| lookup(v.match, "layer4_configs", null) == null | ||
| ? [{ protocol = "all", ports = null }] | ||
| : [ | ||
| for c in v.match.layer4_configs : | ||
| merge({ protocol = "all", ports = null }, c) | ||
| ] | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| factory_ingress_rules = { | ||
| for k, v in local._factory_ingress_rules : "egress/${k}" => { | ||
| action = "allow" | ||
| direction = "INGRESS" | ||
| priority = v.priority | ||
| description = lookup(v, "description", null) | ||
| disabled = lookup(v, "disabled", false) | ||
| enable_logging = lookup(v, "enable_logging", null) | ||
| target_service_accounts = lookup(v, "target_service_accounts", null) | ||
| target_tags = lookup(v, "target_tags", null) | ||
| match = { | ||
| address_groups = lookup(v.match, "address_groups", null) | ||
| fqdns = lookup(v.match, "fqdns", null) | ||
| region_codes = lookup(v.match, "region_codes", null) | ||
| threat_intelligences = lookup(v.match, "threat_intelligences", null) | ||
| destination_ranges = ( | ||
| lookup(v.match, "destination_ranges", null) == null | ||
| ? null | ||
| : flatten([ | ||
| for r in v.match.destination_ranges : | ||
| try(local.factory_cidrs[r], r) | ||
| ]) | ||
| ) | ||
| source_ranges = ( | ||
| lookup(v.match, "source_ranges", null) == null | ||
| ? null | ||
| : flatten([ | ||
| for r in v.match.source_ranges : | ||
| try(local.factory_cidrs[r], r) | ||
| ]) | ||
| ) | ||
| source_tags = lookup(v.match, "source_tags", null) | ||
| layer4_configs = ( | ||
| lookup(v.match, "layer4_configs", null) == null | ||
| ? [{ protocol = "all", ports = null }] | ||
| : [ | ||
| for c in v.match.layer4_configs : | ||
| merge({ protocol = "all", ports = null }, c) | ||
| ] | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.